revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-12 06:48:31 +01:00
Code Issues Releases Wiki Activity

Redirect older "/panel/" settings URIs to modern location

Browse source 
Summary:
Ref T11098. We have a fair number of these, including links in email, which we can't turn into explicit `/user/` URIs.

Just redirect them to the modern places.

Test Plan: Clicked "Customize Menu..." on home page.

Reviewers: chad, avivey

Reviewed By: avivey

Subscribers: avivey

Maniphest Tasks: T11098

Differential Revision: https://secure.phabricator.com/D16049
This commit is contained in:
epriestley 2016-06-05 13:35:25 -07:00
parent 421bf2e548
commit 6ac5f84c8b
2 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/settings/application/PhabricatorSettingsApplication.php
View file

@ -36,6 +36,8 @@ final class PhabricatorSettingsApplication extends PhabricatorApplication {
=> 'PhabricatorSettingsMainController', => 'PhabricatorSettingsMainController',
'builtin/(?P<builtin>global)/'.$panel_pattern 'builtin/(?P<builtin>global)/'.$panel_pattern
=> 'PhabricatorSettingsMainController', => 'PhabricatorSettingsMainController',
'panel/(?P<panel>[^/]+)/'
=> 'PhabricatorSettingsMainController',
'adjust/' => 'PhabricatorSettingsAdjustController', 'adjust/' => 'PhabricatorSettingsAdjustController',
'timezone/(?P<offset>[^/]+)/' 'timezone/(?P<offset>[^/]+)/'
=> 'PhabricatorSettingsTimezoneController', => 'PhabricatorSettingsTimezoneController',

13
src/applications/settings/controller/PhabricatorSettingsMainController.php
View file

@ -30,6 +30,19 @@ final class PhabricatorSettingsMainController
public function handleRequest(AphrontRequest $request) { public function handleRequest(AphrontRequest $request) {
$viewer = $this->getViewer(); $viewer = $this->getViewer();
// Redirect "/panel/XYZ/" to the viewer's personal settings panel. This
// was the primary URI before global settings were introduced and allows
// generation of viewer-agnostic URIs for email.
$panel = $request->getURIData('panel');
if ($panel) {
$panel = phutil_escape_uri($panel);
$username = $viewer->getUsername();
$panel_uri = "/user/{$username}/page/{$panel}/";
$panel_uri = $this->getApplicationURI($panel_uri);
return id(new AphrontRedirectResponse())->setURI($panel_uri);
}
$username = $request->getURIData('username'); $username = $request->getURIData('username');
$builtin = $request->getURIData('builtin'); $builtin = $request->getURIData('builtin');