From 6bada7db4ceb83158d60b0ff1ff79554833f909b Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 6 Nov 2019 07:48:26 -0800 Subject: [PATCH] Change the Herald "do not include [any of]" condition label to "include none of" Summary: Fixes T13445. Make the meaning of this condition more clear, since the current wording is ambiguous between "any of" and "all of". Test Plan: Edited a Herald rule with a PHID list field ("Project tags"), saw text label say "include none of". Maniphest Tasks: T13445 Differential Revision: https://secure.phabricator.com/D20889 --- src/applications/herald/adapter/HeraldAdapter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/herald/adapter/HeraldAdapter.php b/src/applications/herald/adapter/HeraldAdapter.php index 2832c6d9f4..70f6e3d5cb 100644 --- a/src/applications/herald/adapter/HeraldAdapter.php +++ b/src/applications/herald/adapter/HeraldAdapter.php @@ -399,7 +399,7 @@ abstract class HeraldAdapter extends Phobject { self::CONDITION_IS_NOT_ANY => pht('is not any of'), self::CONDITION_INCLUDE_ALL => pht('include all of'), self::CONDITION_INCLUDE_ANY => pht('include any of'), - self::CONDITION_INCLUDE_NONE => pht('do not include'), + self::CONDITION_INCLUDE_NONE => pht('include none of'), self::CONDITION_IS_ME => pht('is myself'), self::CONDITION_IS_NOT_ME => pht('is not myself'), self::CONDITION_REGEXP => pht('matches regexp'),