From 6c2c80a3731c0c6be3d99a8357e6a5a53668001d Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 1 Apr 2022 11:44:41 -0700 Subject: [PATCH] Remove ancient Remarkup constants from Phame and Maniphest Summary: Ref T13661. These constants are no longer used. Test Plan: For a blog with a nonempty description, viewed the "Manage" page and the home page; saw properly rendered description. Grepped for removed constants, no hits. Maniphest Tasks: T13661 Differential Revision: https://secure.phabricator.com/D21749 --- src/applications/maniphest/storage/ManiphestTask.php | 2 -- .../phame/controller/blog/PhameBlogManageController.php | 5 ----- src/applications/phame/storage/PhameBlog.php | 2 -- 3 files changed, 9 deletions(-) diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php index 4f90de3507..46dd8a1547 100644 --- a/src/applications/maniphest/storage/ManiphestTask.php +++ b/src/applications/maniphest/storage/ManiphestTask.php @@ -24,8 +24,6 @@ final class ManiphestTask extends ManiphestDAO PhabricatorPolicyCodexInterface, PhabricatorUnlockableInterface { - const MARKUP_FIELD_DESCRIPTION = 'markup:desc'; - protected $authorPHID; protected $ownerPHID; diff --git a/src/applications/phame/controller/blog/PhameBlogManageController.php b/src/applications/phame/controller/blog/PhameBlogManageController.php index 65378d91cb..a30d036c3f 100644 --- a/src/applications/phame/controller/blog/PhameBlogManageController.php +++ b/src/applications/phame/controller/blog/PhameBlogManageController.php @@ -143,11 +143,6 @@ final class PhameBlogManageController extends PhameBlogController { ), $feed_uri)); - $engine = id(new PhabricatorMarkupEngine()) - ->setViewer($viewer) - ->addObject($blog, PhameBlog::MARKUP_FIELD_DESCRIPTION) - ->process(); - $description = $blog->getDescription(); if (strlen($description)) { $description = new PHUIRemarkupView($viewer, $description); diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php index 232f1fe4db..a68ddac0b0 100644 --- a/src/applications/phame/storage/PhameBlog.php +++ b/src/applications/phame/storage/PhameBlog.php @@ -13,8 +13,6 @@ final class PhameBlog extends PhameDAO PhabricatorFulltextInterface, PhabricatorFerretInterface { - const MARKUP_FIELD_DESCRIPTION = 'markup:description'; - protected $name; protected $subtitle; protected $description;