revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Conpherence - fix a few bugs

Browse source 
Summary:
1) make the page title and uri update appropos to selected widget 2) make a behavior actually listen 3) fix the css so the button can always be clicked to edit metadata

Ref T3035 as I was trying to repro the metadata edit bug there and couldn't.

Test Plan: made the window small enought to have all the widgets visible and be in "device mode". noted page title and uri updated correctly from Conpherence and /conphernece/ to Thread Title and /conpherence/$id/ when toggling between thread list and current thread. made the window small enough to have the title and subtitle fields overlap with the edit button.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, chad

Maniphest Tasks: T3035

Differential Revision: https://secure.phabricator.com/D5754
This commit is contained in:
Bob Trahan 2013-04-22 16:18:18 -07:00
parent 8872d5b6d1
commit 6c5d98bb5e
3 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
webroot/rsrc/css/application/conpherence/header-pane.css
View file

@ -37,39 +37,39 @@
} }
.conpherence-header-pane .title { .conpherence-header-pane .title {
position: relative; position: absolute;
font-size: 16px; font-size: 16px;
font-weight: bold; font-weight: bold;
left: 77px; left: 77px;
top: 21px; top: 21px;
max-width: 80%; right: 66px;
overflow-x: auto; overflow-x: auto;
} }
.conpherence-header-pane .custom-title { .conpherence-header-pane .custom-title {
position: relative; position: absolute;
font-size: 16px; font-size: 16px;
font-weight: bold; font-weight: bold;
left: 132px; left: 132px;
top: 21px; top: 21px;
max-width: 80%; right: 66px;
overflow-x: auto; overflow-x: auto;
} }
.conpherence-header-pane .subtitle { .conpherence-header-pane .subtitle {
position: relative; position: absolute;
left: 77px; left: 77px;
top: 21px; top: 40px;
right: 66px;
color: #bfbfbf; color: #bfbfbf;
max-width: 80%;
} }
.conpherence-header-pane .custom-subtitle { .conpherence-header-pane .custom-subtitle {
position: relative; position: absolute;
left: 132px; left: 132px;
top: 21px; top: 40px;
right: 66px;
color: #bfbfbf; color: #bfbfbf;
max-width: 80%;
} }
.conpherence-header-pane .upload-photo { .conpherence-header-pane .upload-photo {

5
webroot/rsrc/js/application/conpherence/behavior-menu.js
View file

@ -61,6 +61,9 @@ JX.behavior('conpherence-menu', function(config) {
JX.History.replace(config.base_uri + uri_suffix); JX.History.replace(config.base_uri + uri_suffix);
if (data.title) { if (data.title) {
document.title = data.title; document.title = data.title;
} else if (thread.node) {
var threadData = JX.Stratcom.getData(thread.node);
document.title = threadData.title;
} }
} }
@ -173,8 +176,8 @@ JX.behavior('conpherence-menu', function(config) {
} }
JX.Stratcom.listen( JX.Stratcom.listen(
null,
'conpherence-redraw-thread', 'conpherence-redraw-thread',
null,
function (e) { function (e) {
didredrawthread(); didredrawthread();
} }

2
webroot/rsrc/js/application/conpherence/behavior-widget-pane.js
View file

@ -64,7 +64,7 @@ JX.behavior('conpherence-widget-pane', function(config) {
JX.Stratcom.invoke( JX.Stratcom.invoke(
'conpherence-update-page-data', 'conpherence-update-page-data',
null, null,
{ use_base_uri : true } { use_base_uri : true, title: 'Conpherence' }
); );
} }
} else { } else {