From 6cc5f952a4cffdc516d64344420a80e8d367820f Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 13 Jan 2014 16:08:30 -0800 Subject: [PATCH] Fix Herald field type error Summary: See IRC. This is a likely fix for @DctrWatson's error: we're returning `null` but should return `array()` to indicate no values. Test Plan: Will make @DctrWatson do it. Reviewers: btrahan Reviewed By: btrahan CC: dctrwatson, aran Differential Revision: https://secure.phabricator.com/D7950 --- .../herald/adapter/HeraldDifferentialRevisionAdapter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php b/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php index 87c6357902..6b3fb49fd0 100644 --- a/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php +++ b/src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php @@ -353,7 +353,7 @@ final class HeraldDifferentialRevisionAdapter extends HeraldAdapter { case self::FIELD_REPOSITORY_PROJECTS: $repository = $this->loadRepository(); if (!$repository) { - return null; + return array(); } return $repository->getProjectPHIDs(); case self::FIELD_DIFF_CONTENT: