revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-21 21:10:56 +01:00
Code Issues Releases Wiki Activity

Fix an issue with handle loads; the inner loop expects $objects to have only objects of the given type.

Browse source 
Auditors: btrahan
This commit is contained in:
epriestley 2013-07-21 07:03:47 -07:00
parent 7ed6996604
commit 6cdb02fc7e
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/phid/handle/PhabricatorObjectHandleData.php
View file

@ -241,13 +241,14 @@ final class PhabricatorObjectHandleData {
} }
public function loadHandles() { public function loadHandles() {
$objects = $this->loadObjects(); $all_objects = $this->loadObjects();
$types = phid_group_by_type($this->phids); $types = phid_group_by_type($this->phids);
$handles = array(); $handles = array();
foreach ($types as $type => $phids) { foreach ($types as $type => $phids) {
$objects = array_select_keys($all_objects, $phids);
switch ($type) { switch ($type) {
case PhabricatorPHIDConstants::PHID_TYPE_MAGIC: case PhabricatorPHIDConstants::PHID_TYPE_MAGIC: