revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 01:08:50 +02:00
Code Issues Releases Wiki Activity

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Browse Repositories overlay dialog

Browse source 
Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15420

Test Plan: Applied these two changes; afterwards "Browse Repositories" overlay dialog gets rendered in web browser and lists existing repositories.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15420

Differential Revision: https://we.phorge.it/D25244
This commit is contained in:
Andre Klapper 2023-05-24 18:09:48 +02:00
parent 26d74ccc7c
commit 6d57904330
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diffusion/typeahead/DiffusionRepositoryDatasource.php
View file

@ -41,7 +41,7 @@ final class DiffusionRepositoryDatasource
$parts[] = $name; $parts[] = $name;
$slug = $repository->getRepositorySlug(); $slug = $repository->getRepositorySlug();
if (strlen($slug)) { if (phutil_nonempty_string($slug)) {
$parts[] = $slug; $parts[] = $slug;
} }

2
src/applications/repository/storage/PhabricatorRepository.php
View file

@ -217,7 +217,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
$monograms[] = 'R'.$this->getID(); $monograms[] = 'R'.$this->getID();
$callsign = $this->getCallsign(); $callsign = $this->getCallsign();
if (strlen($callsign)) { if (phutil_nonempty_string($callsign)) {
$monograms[] = 'r'.$callsign; $monograms[] = 'r'.$callsign;
} }