mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 14:00:56 +01:00
Fix PHP 8.1 "strlen(null)" exceptions which block rendering Browse Repositories overlay dialog
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. Closes T15420 Test Plan: Applied these two changes; afterwards "Browse Repositories" overlay dialog gets rendered in web browser and lists existing repositories. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15420 Differential Revision: https://we.phorge.it/D25244
This commit is contained in:
parent
26d74ccc7c
commit
6d57904330
2 changed files with 2 additions and 2 deletions
|
@ -41,7 +41,7 @@ final class DiffusionRepositoryDatasource
|
|||
$parts[] = $name;
|
||||
|
||||
$slug = $repository->getRepositorySlug();
|
||||
if (strlen($slug)) {
|
||||
if (phutil_nonempty_string($slug)) {
|
||||
$parts[] = $slug;
|
||||
}
|
||||
|
||||
|
|
|
@ -217,7 +217,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
|
|||
$monograms[] = 'R'.$this->getID();
|
||||
|
||||
$callsign = $this->getCallsign();
|
||||
if (strlen($callsign)) {
|
||||
if (phutil_nonempty_string($callsign)) {
|
||||
$monograms[] = 'r'.$callsign;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue