From 6d7b78f791f0030236095b6236485585d3004d61 Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 28 Sep 2015 11:17:04 -0700 Subject: [PATCH] (stable) Fix issue with "Publish/Notify" handling in repositories Summary: Fixes T8728. As far as I can tell, I simply got this wrong in D11826. This is not the proper name for the preference. That change primarily focused on the "spammy junk during import" issue, and the code did get the importing flag right. It looks like my testing in D11827 focused on "during import" and just missed this case. Test Plan: Grepped for `disable-herald`. Grepped for `herald-disable`. Reviewers: chad Reviewed By: chad Maniphest Tasks: T8728 Differential Revision: https://secure.phabricator.com/D14181 --- src/applications/repository/storage/PhabricatorRepository.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/repository/storage/PhabricatorRepository.php b/src/applications/repository/storage/PhabricatorRepository.php index d5b128292a..084f531a10 100644 --- a/src/applications/repository/storage/PhabricatorRepository.php +++ b/src/applications/repository/storage/PhabricatorRepository.php @@ -715,7 +715,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO return false; } - if ($this->getDetail('disable-herald')) { + if ($this->getDetail('herald-disabled')) { return false; }