mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-26 23:40:57 +01:00
Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Summary: Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing. Add the conversion step. Test Plan: Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal. Maniphest Tasks: T13513 Differential Revision: https://secure.phabricator.com/D21239
This commit is contained in:
parent
e7ebd5d9d1
commit
6dc20d1e2e
1 changed files with 2 additions and 0 deletions
|
@ -234,6 +234,8 @@ final class DifferentialRevisionViewController
|
|||
->withPublishedComments(true)
|
||||
->execute();
|
||||
|
||||
$inlines = mpull($inlines, 'newInlineCommentObject');
|
||||
|
||||
$inlines = id(new PhabricatorInlineCommentAdjustmentEngine())
|
||||
->setViewer($viewer)
|
||||
->setRevision($revision)
|
||||
|
|
Loading…
Reference in a new issue