revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 18:22:41 +01:00
Code Issues Releases Wiki Activity

Fix an issue where storage inlines are fed to InlineAdjustmentEngine

Browse source 
Summary:
Ref T13513. If an intradiff has at least one unchanged file ("hasSameEffectAs()") or more than 100 files ("Large Change"), we hit this block and don't upcast storage inlines to runtime inlines. I missed this in testing.

Add the conversion step.

Test Plan: Viewed an intradiff with at least one unchanged file and at least one inline comment, saw correct rendering instead of fatal.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21239
This commit is contained in:
epriestley 2020-05-08 16:49:14 -07:00
parent e7ebd5d9d1
commit 6dc20d1e2e
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/controller/DifferentialRevisionViewController.php
View file

@ -234,6 +234,8 @@ final class DifferentialRevisionViewController
->withPublishedComments(true) ->withPublishedComments(true)
->execute(); ->execute();
$inlines = mpull($inlines, 'newInlineCommentObject');
$inlines = id(new PhabricatorInlineCommentAdjustmentEngine()) $inlines = id(new PhabricatorInlineCommentAdjustmentEngine())
->setViewer($viewer) ->setViewer($viewer)
->setRevision($revision) ->setRevision($revision)