From 6de8fe418c57fec6726f223ad406be9be7979f9b Mon Sep 17 00:00:00 2001
From: Bob Trahan <btrahan@phacility.com>
Date: Tue, 6 Jan 2015 14:41:28 -0800
Subject: [PATCH] Conduit - document that ERR-CONDUIT-CORE is coming atchya

Summary: Fixes T6863. Seems like this belongs there?

Test Plan: loaded up an API in conduit console and saw the new error text

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6863

Differential Revision: https://secure.phabricator.com/D11261
---
 .../PhabricatorConduitConsoleController.php   | 20 ++++++++-----------
 1 file changed, 8 insertions(+), 12 deletions(-)

diff --git a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
index 7da3f4851f..aa541bdd06 100644
--- a/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
+++ b/src/applications/conduit/controller/PhabricatorConduitConsoleController.php
@@ -49,19 +49,15 @@ final class PhabricatorConduitConsoleController
     }
 
     $error_types = $method->defineErrorTypes();
-    if ($error_types) {
-      $error_description = array();
-      foreach ($error_types as $error => $meaning) {
-        $error_description[] = hsprintf(
-          '<li><strong>%s:</strong> %s</li>',
-          $error,
-          $meaning);
-      }
-      $error_description = phutil_tag('ul', array(), $error_description);
-    } else {
-      $error_description = pht(
-        'This method does not raise any specific errors.');
+    $error_types['ERR-CONDUIT-CORE'] = pht('See error message for details.');
+    $error_description = array();
+    foreach ($error_types as $error => $meaning) {
+      $error_description[] = hsprintf(
+        '<li><strong>%s:</strong> %s</li>',
+        $error,
+        $meaning);
     }
+    $error_description = phutil_tag('ul', array(), $error_description);
 
     $form = new AphrontFormView();
     $form