revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-22 03:29:11 +01:00
Code Issues Releases Wiki Activity

Don't show proxy (subproject/milestone) columns as options in "Move tasks..." workflows from workboards

Browse source 
Summary:
Ref T13368. Proxy columns should not be selectable from this workflow. If you want to move tasks to milestone/subproject X, do "Move tasks to project..." and pick X as the project.

(This could be made to work some day.)

Test Plan: Went through a "Move tasks to project..." workflow targeting a project with subprojects. No longer saw subproject columns presented as dropdown options.

Maniphest Tasks: T13368

Differential Revision: https://secure.phabricator.com/D20699
This commit is contained in:
epriestley 2019-08-07 08:59:34 -07:00
parent 31254c5124
commit 6deac35659
1 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/applications/project/controller/PhabricatorProjectColumnBulkMoveController.php
View file

@ -109,6 +109,15 @@ final class PhabricatorProjectColumnBulkMoveController
$dst_columns = $layout_engine->getColumns($dst_project->getPHID());
$dst_columns = mpull($dst_columns, null, 'getPHID');
// Prevent moves to milestones or subprojects by selecting their
// columns, since the implications aren't obvious and this doesn't
// work the same way as normal column moves.
foreach ($dst_columns as $key => $dst_column) {
if ($dst_column->getProxyPHID()) {
unset($dst_columns[$key]);
}
}
$has_column = false;
$dst_column = null;