1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-21 22:32:41 +01:00

Fix additional "xprintf()"-class static parameter lint errors

Summary: Ref T13577. After the fix in D21453, lint identifies additional static errors in Phabricator; fix them.

Test Plan: Ran `arc lint`; these messages are essentially all very obscure.

Subscribers: hach-que, yelirekim, PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13577

Differential Revision: https://secure.phabricator.com/D21457
This commit is contained in:
epriestley 2020-09-08 08:53:39 -07:00
parent 7daaaa8463
commit 6e1b5da112
18 changed files with 30 additions and 14 deletions

View file

@ -40,7 +40,8 @@ foreach ($lists as $list) {
if (!$username_okay) {
echo pht(
'Failed to migrate mailing list "%s": unable to generate a unique '.
'username for it.')."\n";
'username for it.',
$name)."\n";
continue;
}

View file

@ -36,7 +36,8 @@ final class PhabricatorDifferentialRebuildChangesetsWorkflow
throw new PhutilArgumentUsageException(
pht(
'Object "%s" specified by "--revision" must be a Differential '.
'revision.'));
'revision.',
$revision_identifier));
}
} else {
$revision = id(new DifferentialRevisionQuery())

View file

@ -84,7 +84,8 @@ final class DifferentialRevisionRepositoryTransaction
$errors[] = $this->newInvalidError(
pht(
'Repository "%s" is not a valid repository, or you do not have '.
'permission to view it.'),
'permission to view it.',
$new_value),
$xaction);
}
}

View file

@ -43,6 +43,7 @@ final class PhabricatorChartFunctionArgumentParser
pht(
'Chart function "%s" emitted an argument specification ("%s") with '.
'no type. Each argument specification must have a valid type.',
$this->getFunctionArgumentSignature(),
$name));
}

View file

@ -54,6 +54,7 @@ final class HarbormasterManagementPublishWorkflow
pht(
'Object "%s" is not a HarbormasterBuildable (it is a "%s"). '.
'Name one or more buildables to publish, like "B123".',
$name,
get_class($result)));
}
}

View file

@ -177,6 +177,8 @@ final class HarbormasterBuildLog
pht(
'Attempt to load log bytes (%d - %d) failed: failed to '.
'load a single contiguous range. Actual ranges: %s.',
$offset,
$end,
implode('; ', $display_ranges)));
}

View file

@ -199,8 +199,7 @@ final class ManiphestTaskPriority extends ManiphestConstants {
throw new Exception(
pht(
'Configuration is not valid. Maniphest priority configurations '.
'must be dictionaries.',
$config));
'must be dictionaries.'));
}
$all_keywords = array();

View file

@ -65,6 +65,7 @@ abstract class PhabricatorMailAdapter
pht(
'Adapter ("%s") is configured for medium "%s", but this is not '.
'a supported delivery medium. Supported media are: %s.',
get_class($this),
$medium,
implode(', ', $native_map)));
}

View file

@ -98,7 +98,9 @@ final class PhabricatorNotificationServersConfigType
'Notification server configuration describes an invalid host '.
'("%s", at index "%s"). This is an "admin" service but it has a '.
'"path" property. This property is only valid for "client" '.
'services.'));
'services.',
$host,
$index));
}
// We can't guarantee that you didn't just give the same host two

View file

@ -85,7 +85,8 @@ final class NuanceGitHubRawEventTestCase
throw new Exception(
pht(
'Expected test file "%s" to contain exactly two sections, '.
'but it has more than two sections.'));
'but it has more than two sections.',
$file));
}
list($input, $expect) = $parts;

View file

@ -71,7 +71,6 @@ final class PhragmentRevertController extends PhragmentController {
->appendParagraph(pht(
'Reverting this fragment to version %d will create a new version of '.
'the fragment. It will not delete any version history.',
$version->getSequence(),
$version->getSequence()));
return id(new AphrontDialogResponse())->setDialog($dialog);
}

View file

@ -266,8 +266,7 @@ final class PhabricatorPolicy
return pht(
'Members of a particular project can take this action. (You '.
'can not see this object, so the name of this project is '.
'restricted.)',
$handle->getFullName());
'restricted.)');
} else if ($type == PhabricatorPeopleUserPHIDType::TYPECONST) {
return pht(
'%s can take this action.',

View file

@ -224,6 +224,7 @@ final class PhabricatorProjectIconSet
'Icon key "%s" is not a valid icon key. Icon keys must be 1-32 '.
'characters long and contain only lowercase letters. For example, '.
'"%s" and "%s" are reasonable keys.',
$value['key'],
'tag',
'group'));
}

View file

@ -17,7 +17,8 @@ abstract class FerretSearchFunction
pht(
'Ferret search engine function name ("%s") is invalid. Function '.
'names must be nonempty and may only contain latin letters and '.
'hyphens.'));
'hyphens.',
$function_name));
}
}
@ -77,6 +78,7 @@ abstract class FerretSearchFunction
'Ferret function "%s" is specified with a denormalized name. '.
'Instead, specify the function using the normalized '.
'function name ("%s").',
$function_name,
$normal_name));
}

View file

@ -2548,7 +2548,9 @@ abstract class PhabricatorEditEngine
pht(
'Extension "%s" defines a bulk edit group with the same key '.
'("%s") as the main editor or another extension. Each bulk '.
'edit group must have a unique key.'));
'edit group must have a unique key.',
get_class($extension),
$key));
}
$map[$key] = $group;

View file

@ -204,7 +204,8 @@ final class PhabricatorEditEngineSubtype
pht(
'Subtype configuration is invalid: subtype with key "%s" '.
'specifies both child subtypes and child forms. Specify one '.
'or the other, but not both.'));
'or the other, but not both.',
$key));
}
}

View file

@ -205,6 +205,8 @@ final class PhabricatorDatabaseRefParser
'Database "%s" is configured as a replica and specifies a '.
'master ("%s"), but that master is not a valid master. Valid '.
'masters are: %s.',
$ref->getRefKey(),
$master_key,
implode(', ', $master_keys)));
}

View file

@ -22,7 +22,7 @@ final class PhabricatorCustomFieldApplicationSearchNoneFunctionDatasource
'summary' => pht('Find results with no value.'),
'description' => pht(
"This function includes results which have no value. Use a query ".
"like this to find results with no value:\n\n%s\n\n",
"like this to find results with no value:\n\n%s\n\n".
'If you combine this function with other constraints, results '.
'which have no value or the specified values will be returned.',
'> any()'),