revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 21:02:41 +01:00
Code Issues Releases Wiki Activity

Fix "edit" for Maniphest comments

Browse source 
Summary:
Ref T2217. Fixes T3876. We incorrectly have a unique key on `(authorPHID, transactionPHID)`, which prevents saving multiple versions of a comment.

I'm not entirely sure why this exists. I think it came from Pholio (where it works for inlines, because it has an additional component, but maybe should be adjusted) but we might need to wipe it out of more apps too.

Test Plan: Edited a comment in Maniphest.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2217, T3876

Differential Revision: https://secure.phabricator.com/D7102
This commit is contained in:
epriestley 2013-09-24 11:10:31 -07:00
parent 79ec5222a5
commit 6e29e809b4
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
resources/sql/patches/20130924.mdraftkey.sql Normal file
View file

@ -0,0 +1,2 @@
ALTER TABLE {$NAMESPACE}_maniphest.maniphest_transaction_comment
DROP KEY `key_draft`;

4
src/infrastructure/storage/patch/PhabricatorBuiltinPatchList.php
View file

@ -1624,6 +1624,10 @@ final class PhabricatorBuiltinPatchList extends PhabricatorSQLPatchList {
'type' => 'sql', 'type' => 'sql',
'name' => $this->getPatchPath('20130923.mrename.sql'), 'name' => $this->getPatchPath('20130923.mrename.sql'),
), ),
'20130924.mdraftkey.sql' => array(
'type' => 'sql',
'name' => $this->getPatchPath('20130924.mdraftkey.sql'),
),
); );
} }
} }