revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Fix a dashboard bucketing bug

Browse source 
Summary: Ref T10939. For various historical reasons, revision status is a numeric string. This comparison fails because it's `(string) !== (int)`. Just use `!=` so this will still work if we turn it into a real string in the future.

Test Plan: Tried a more specific test case locally, got better looking results in "Must Review" and "Should Review".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15928
This commit is contained in:
epriestley 2016-05-16 11:02:42 -07:00
parent 8a98868bfb
commit 6e9828c743
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/query/DifferentialRevisionResultBucket.php
View file

@ -17,7 +17,7 @@ abstract class DifferentialRevisionResultBucket
$status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW; $status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;
foreach ($objects as $key => $object) { foreach ($objects as $key => $object) {
if ($object->getStatus() !== $status_review) { if ($object->getStatus() != $status_review) {
continue; continue;
} }