From 6ea9aa39a08adb4952f77b106c59cd18a626882b Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 21 Jan 2016 16:21:48 -0800 Subject: [PATCH] Fix quicksand interaction with HTTP GET prefilling in ApplicationSearch Summary: Fixes T10196. This is a weird interaction and this might not be the best long-term fix, but just get it working OK for now. General problem is that Quicksand doesn't currently use GET for requests. This is a very unusual case where the method is relevant. In the future, I might change Quicksand to use GET. Test Plan: Clicked "Open Tasks" with Quicksand active, got a results list. Reviewers: chad Reviewed By: chad Maniphest Tasks: T10196 Differential Revision: https://secure.phabricator.com/D15082 --- .../controller/PhabricatorApplicationSearchController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php index 186e6474cd..3b30d5d30c 100644 --- a/src/applications/search/controller/PhabricatorApplicationSearchController.php +++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php @@ -100,7 +100,7 @@ final class PhabricatorApplicationSearchController } else if (!strlen($this->queryKey)) { $found_query_data = false; - if ($request->isHTTPGet()) { + if ($request->isHTTPGet() || $request->isQuicksand()) { // If this is a GET request and it has some query data, don't // do anything unless it's only before= or after=. We'll build and // execute a query from it below. This allows external tools to build