revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-11 08:06:13 +01:00
Code Issues Releases Wiki Activity

Make maniphest.gettasktransactions include metadata and title

Browse source 
Summary:
Include task title and metadata in Conduit's `maniphest.gettasktransactions` output.
This data can for example be used by IRC bots to improve their output (e.g. conditions which changes [not] to emit or text coloring based on metadata).

Upstreaming from https://phabricator.wikimedia.org/rPHABf2fd14dc1edeb41aa2874336548cfaa7fa0e87a0

NOTE: this specific API is in "frozen" status. This method is frozen and will eventually be deprecated. New code should use "transaction.search" instead.

Closes T15916

Test Plan: Call `maniphest.gettasktransactions` on a task, see two additional fields.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15916

Differential Revision: https://we.phorge.it/D25777
This commit is contained in:
Andre Klapper 2024-08-14 15:16:28 +02:00
parent 828ea9bca0
commit 6ec5c88bee
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/maniphest/conduit/ManiphestGetTaskTransactionsConduitAPIMethod.php
View file

@ -69,11 +69,13 @@ final class ManiphestGetTaskTransactionsConduitAPIMethod
$results[$task_id][] = array( $results[$task_id][] = array(
'taskID' => $task_id, 'taskID' => $task_id,
'title' => (string)$transaction->getTitleForTextMail(),
'transactionID' => $transaction->getID(), 'transactionID' => $transaction->getID(),
'transactionPHID' => $transaction->getPHID(), 'transactionPHID' => $transaction->getPHID(),
'transactionType' => $transaction->getTransactionType(), 'transactionType' => $transaction->getTransactionType(),
'oldValue' => $transaction->getOldValue(), 'oldValue' => $transaction->getOldValue(),
'newValue' => $transaction->getNewValue(), 'newValue' => $transaction->getNewValue(),
'meta' => $transaction->getMetadata(),
'comments' => $comments, 'comments' => $comments,
'authorPHID' => $transaction->getAuthorPHID(), 'authorPHID' => $transaction->getAuthorPHID(),
'dateCreated' => $transaction->getDateCreated(), 'dateCreated' => $transaction->getDateCreated(),