revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-20 05:42:40 +01:00
Code Issues Releases Wiki Activity

Greyed out some icons, removed colors from Phriction updates

Browse source 
Summary:
@chad The colors were indeed terrible. Why didn't you tell me

Also greyed out diff icons when no diff available. Makes it more clear that you can't click it on mobile.

Test Plan: Saw it on mobile and desktop.

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5694
This commit is contained in:
Anh Nhan Nguyen 2013-04-15 05:17:48 -07:00 committed by epriestley
parent 4c2a87f208
commit 6efe8d4a9d
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/phriction/controller/PhrictionListController.php
View file

@ -163,11 +163,9 @@ final class PhrictionListController
switch ($content->getChangeType()) { switch ($content->getChangeType()) {
case PhrictionChangeType::CHANGE_DELETE: case PhrictionChangeType::CHANGE_DELETE:
$change_type = pht('%s deleted %s', $author, $document_link); $change_type = pht('%s deleted %s', $author, $document_link);
$color = 'red';
break; break;
case PhrictionChangeType::CHANGE_EDIT: case PhrictionChangeType::CHANGE_EDIT:
$change_type = pht('%s edited %s', $author, $document_link); $change_type = pht('%s edited %s', $author, $document_link);
$color = 'blue';
break; break;
case PhrictionChangeType::CHANGE_MOVE_HERE: case PhrictionChangeType::CHANGE_MOVE_HERE:
case PhrictionChangeType::CHANGE_MOVE_AWAY: case PhrictionChangeType::CHANGE_MOVE_AWAY:
@ -180,11 +178,9 @@ final class PhrictionListController
if ($change_type == PhrictionChangeType::CHANGE_MOVE_HERE) { if ($change_type == PhrictionChangeType::CHANGE_MOVE_HERE) {
$change_type = pht('%s moved %s from %s', $author, $document_link, $change_type = pht('%s moved %s from %s', $author, $document_link,
$ref_doc_link); $ref_doc_link);
$color = 'yellow';
} else { } else {
$change_type = pht('%s moved %s to %s', $author, $document_link, $change_type = pht('%s moved %s to %s', $author, $document_link,
$ref_doc_link); $ref_doc_link);
$color = 'orange';
} }
break; break;
default: default:
@ -194,7 +190,6 @@ final class PhrictionListController
$item = id(new PhabricatorObjectItemView()) $item = id(new PhabricatorObjectItemView())
->setHeader($change_type) ->setHeader($change_type)
->setBarColor($color)
->addAttribute(phabricator_datetime($content->getDateCreated(), $user)) ->addAttribute(phabricator_datetime($content->getDateCreated(), $user))
->addAttribute($slug_uri); ->addAttribute($slug_uri);
@ -207,7 +202,7 @@ final class PhrictionListController
$uri = $diff_uri->alter('l', $version - 1)->alter('r', $version); $uri = $diff_uri->alter('l', $version - 1)->alter('r', $version);
$item->addIcon('history', pht('View Change'), $uri); $item->addIcon('history', pht('View Change'), $uri);
} else { } else {
$item->addIcon('history', pht('No diff available')); $item->addIcon('history-grey', pht('No diff available'));
} }
return $item; return $item;