Paginate the profile badges view

Summary: Ref T12270. Adds a pager, plus a few little cleanups from copy/paste and accumulated cruft.

Test Plan:
  - Paginated a user with 180 badges.
  - Viewed a user with 0 badges.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12270

Differential Revision: https://secure.phabricator.com/D17561

src/applications/people/controller/PhabricatorPeopleProfileBadgesController.php

@@ -10,13 +10,7 @@ final class PhabricatorPeopleProfileBadgesController
     $user = id(new PhabricatorPeopleQuery())
       ->setViewer($viewer)
       ->withIDs(array($id))
-      ->needProfile(true)
       ->needProfileImage(true)
-      ->needAvailability(true)
-      ->requireCapabilities(
-        array(
-          PhabricatorPolicyCapability::CAN_VIEW,
-        ))
       ->executeOne();
     if (!$user) {
       return new Aphront404Response();
@@ -50,6 +44,7 @@ final class PhabricatorPeopleProfileBadgesController
           PhabricatorPolicyCapability::CAN_VIEW,
           PhabricatorPolicyCapability::CAN_EDIT,
         ))
+      ->setLimit(1)
       ->execute();
 
     $button = id(new PHUIButtonView())
@@ -59,7 +54,7 @@ final class PhabricatorPeopleProfileBadgesController
       ->setWorkflow(true)
       ->setHref('/badges/award/'.$user->getID().'/');
 
-    if (count($badges)) {
+    if ($badges) {
       $header->addActionLink($button);
     }
 
@@ -80,28 +75,25 @@ final class PhabricatorPeopleProfileBadgesController
 
   private function buildBadgesView(PhabricatorUser $user) {
     $viewer = $this->getViewer();
+    $request = $this->getRequest();
 
-    $awards = id(new PhabricatorBadgesAwardQuery())
+    $pager = id(new AphrontCursorPagerView())
+      ->readFromRequest($request);
+
+    $query = id(new PhabricatorBadgesAwardQuery())
       ->setViewer($viewer)
       ->withRecipientPHIDs(array($user->getPHID()))
-      ->withBadgeStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE))
+      ->withBadgeStatuses(array(PhabricatorBadgesBadge::STATUS_ACTIVE));
-      ->execute();
-    $awards = mpull($awards, null, 'getBadgePHID');
 
-    $badges = array();
+    $awards = $query->executeWithCursorPager($pager);
+
+    if ($awards) {
+      $flex = new PHUIBadgeBoxView();
       foreach ($awards as $award) {
         $badge = $award->getBadge();
-      $badges[$award->getBadgePHID()] = $badge;
-    }
 
-    if (count($badges)) {
-      $flex = new PHUIBadgeBoxView();
-
-      foreach ($badges as $badge) {
-        if ($badge) {
         $awarder_info = array();
 
-          $award = idx($awards, $badge->getPHID(), null);
         $awarder_phid = $award->getAwarderPHID();
         $awarder_handle = $viewer->renderHandle($awarder_phid);
         $awarded_date = phabricator_date($award->getDateCreated(), $viewer);
@@ -121,13 +113,15 @@ final class PhabricatorPeopleProfileBadgesController
 
         $flex->addItem($item);
       }
-      }
     } else {
       $flex = id(new PHUIInfoView())
         ->setSeverity(PHUIInfoView::SEVERITY_NOTICE)
         ->appendChild(pht('User has not been awarded any badges.'));
     }
 
-    return $flex;
+    return array(
+      $flex,
+      $pager,
+    );
   }
 }