mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 08:52:39 +01:00
Fix a bad getURI() call in Profile Panel handle construction
Summary: Fixes T11285. We can end up loading panel handles while processing edits (e.g., disabling menu items on a project). We probably started loading these after the modular transaction changes in T9789, which load the handle for the transaction object unconditionally. The handles aren't too useful, but they currently fail to load/build because panels don't have a URI. We could give them some sort of method here, but just nuke it for now since they don't appear anywhere and this unclogs the daemon queue. Test Plan: - Disabled a menu item on a project. - Ran publish task with `bin/worker execute --id <id>`. - Before patch: fatal on getURI() with stack trace similar to T11285. - After patch: clean execution. Reviewers: chad, avivey Reviewed By: avivey Maniphest Tasks: T11285 Differential Revision: https://secure.phabricator.com/D16249
This commit is contained in:
parent
ef13b0e52b
commit
7050506267
1 changed files with 0 additions and 1 deletions
|
@ -33,7 +33,6 @@ final class PhabricatorProfilePanelPHIDType
|
|||
$config = $objects[$phid];
|
||||
|
||||
$handle->setName(pht('Profile Panel'));
|
||||
$handle->setURI($config->getURI());
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue