From 70a2a653ff237f62b9ce0a689bf8cf87cb249b72 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 22 Jan 2013 12:26:52 -0800
Subject: [PATCH] Revert D4359 and apply a better fix

Summary:
In D4359 I fixed an error with 'lint' in SVN repositories, but created an error with the 'lint' column in Javascript. Specifically, when we load the column information over Ajax, we now always include a 'lint' key, even if there is no lint column.

Instead, access the 'lint' property conditionally (so SVN works) but don't include the key if there's no data (so Javascript works).

Test Plan: Loaded SVN, non-SVN non-lint, non-SVN+lint repositories. Everything appeared to work correctly.

Reviewers: asherkin, codeblock

Reviewed By: codeblock

CC: aran

Differential Revision: https://secure.phabricator.com/D4578
---
 src/applications/diffusion/view/DiffusionBrowseTableView.php | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/applications/diffusion/view/DiffusionBrowseTableView.php b/src/applications/diffusion/view/DiffusionBrowseTableView.php
index e104a3a051..004faf0a21 100644
--- a/src/applications/diffusion/view/DiffusionBrowseTableView.php
+++ b/src/applications/diffusion/view/DiffusionBrowseTableView.php
@@ -72,7 +72,6 @@ final class DiffusionBrowseTableView extends DiffusionView {
       'time'      => $time,
       'author'    => $author,
       'details'   => $details,
-      'lint'      => null,
     );
 
     $lint = self::loadLintMessagesCount($drequest);
@@ -218,7 +217,7 @@ final class DiffusionBrowseTableView extends DiffusionView {
         $this->linkHistory($base_path.$path->getPath().$dir_slash),
         $editor_button,
         $browse_link,
-        $dict['lint'],
+        idx($dict, 'lint'),
         $dict['commit'],
         $dict['date'],
         $dict['time'],