From 70b194398e45e47a6b705eb5ef542113f5a274ad Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 23 May 2016 17:04:27 -0700 Subject: [PATCH] (stable) Fix "Reviewers" validation issue with empty reviewers Summary: Fixes T11021. Test Plan: Created a revision without reviewers. Reviewers: chad Reviewed By: chad Maniphest Tasks: T11021 Differential Revision: https://secure.phabricator.com/D15968 --- .../differential/customfield/DifferentialReviewersField.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/applications/differential/customfield/DifferentialReviewersField.php b/src/applications/differential/customfield/DifferentialReviewersField.php index f77f8ab749..41a4cf8f26 100644 --- a/src/applications/differential/customfield/DifferentialReviewersField.php +++ b/src/applications/differential/customfield/DifferentialReviewersField.php @@ -237,6 +237,10 @@ final class DifferentialReviewersField } public function validateCommitMessageValue($value) { + if (!$value) { + return; + } + $author_phid = $this->getObject()->getAuthorPHID(); $config_self_accept_key = 'differential.allow-self-accept';