From 70bf63bc3adc0705ee3667d6bbf315643dea3f33 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 4 Dec 2018 05:50:54 -0800 Subject: [PATCH] Fix a transaction editor "continue;" inside "switch()" for PHP 7.3 Summary: See . This "continue" should be a "break". Test Plan: {F6045490} - Tried to assign a task to myself while I was already the owner, got an appropriate error. Reviewers: amckinley Reviewed By: amckinley Differential Revision: https://secure.phabricator.com/D19844 --- .../maniphest/editor/ManiphestTransactionEditor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/maniphest/editor/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/ManiphestTransactionEditor.php index 4b6c7707f6..47a6b1b4f2 100644 --- a/src/applications/maniphest/editor/ManiphestTransactionEditor.php +++ b/src/applications/maniphest/editor/ManiphestTransactionEditor.php @@ -649,7 +649,7 @@ final class ManiphestTransactionEditor $old_value = $object->getOwnerPHID(); $new_value = $xaction->getNewValue(); if ($old_value === $new_value) { - continue; + break; } // When a task is reassigned, move the old owner to the subscriber