From 70d5e82253a3a179d52527e0415ac31b2df61c55 Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Tue, 30 Jun 2015 15:24:07 -0700
Subject: [PATCH] [Redesign] Clean up borders on ObjectItems

Summary: Ref T8099. A wild border appears!

Test Plan: Remove border when `barColor` is present. Test workboards and Maniphest.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13494
---
 resources/celerity/map.php                           | 6 +++---
 src/view/phui/PHUIObjectItemView.php                 | 2 ++
 webroot/rsrc/css/phui/phui-object-item-list-view.css | 8 +++++++-
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index af51605f06..b2a9a3c2d6 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -7,7 +7,7 @@
  */
 return array(
   'names' => array(
-    'core.pkg.css' => '53a0131b',
+    'core.pkg.css' => '92a58b45',
     'core.pkg.js' => 'a590b451',
     'darkconsole.pkg.js' => 'e7393ebb',
     'differential.pkg.css' => 'cf384ffa',
@@ -141,7 +141,7 @@ return array(
     'rsrc/css/phui/phui-info-view.css' => '5b16bac6',
     'rsrc/css/phui/phui-list.css' => '02ab3534',
     'rsrc/css/phui/phui-object-box.css' => '3db9f358',
-    'rsrc/css/phui/phui-object-item-list-view.css' => '2b126bca',
+    'rsrc/css/phui/phui-object-item-list-view.css' => '0053b016',
     'rsrc/css/phui/phui-pager.css' => 'bea33d23',
     'rsrc/css/phui/phui-pinboard-view.css' => '2495140e',
     'rsrc/css/phui/phui-property-list-view.css' => '1baf23eb',
@@ -785,7 +785,7 @@ return array(
     'phui-inline-comment-view-css' => 'e862e60b',
     'phui-list-view-css' => '02ab3534',
     'phui-object-box-css' => '3db9f358',
-    'phui-object-item-list-view-css' => '2b126bca',
+    'phui-object-item-list-view-css' => '0053b016',
     'phui-pager-css' => 'bea33d23',
     'phui-pinboard-view-css' => '2495140e',
     'phui-property-list-view-css' => '1baf23eb',
diff --git a/src/view/phui/PHUIObjectItemView.php b/src/view/phui/PHUIObjectItemView.php
index b545aa1cd6..eba71b39fd 100644
--- a/src/view/phui/PHUIObjectItemView.php
+++ b/src/view/phui/PHUIObjectItemView.php
@@ -268,6 +268,8 @@ final class PHUIObjectItemView extends AphrontTagView {
 
     if ($this->barColor) {
       $item_classes[] = 'phui-object-item-bar-color-'.$this->barColor;
+    } else {
+      $item_classes[] = 'phui-object-item-no-bar';
     }
 
     if ($this->actions) {
diff --git a/webroot/rsrc/css/phui/phui-object-item-list-view.css b/webroot/rsrc/css/phui/phui-object-item-list-view.css
index d3858ef748..cd01c8820f 100644
--- a/webroot/rsrc/css/phui/phui-object-item-list-view.css
+++ b/webroot/rsrc/css/phui/phui-object-item-list-view.css
@@ -48,12 +48,18 @@ ul.phui-object-item-list-view {
 }
 
 .phui-object-item-frame {
-  border: 1px solid {$lightgreyborder};
+  border-color: {$lightblueborder};
+  border-width: 1px 1px 1px 0;
+  border-style: solid;
   position: relative;
   min-height: 33px;
   overflow: hidden;
 }
 
+.phui-object-item-no-bar .phui-object-item-frame {
+  border-width: 1px;
+}
+
 .device-desktop .phui-object-item {
   margin: 0 0 4px 0;
 }