mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 01:02:42 +01:00
Allow packages to be added as revision reviewers via the UI
Summary: Ref T10939. This lets you add packages as reviewers manually. "Project Reviewers" now lists both projects and packages. I have renamed this to "Coalition Reviewers" but that's probably horrible and confusing. I'm not sure "Group Reviewers" is much better. Test Plan: - Added a package as a reviewer manually. - Joined it, got authority over it. - Saw the review on my dashboard. - Accepted the revision, got authority extended to the package review. {F1311652} {F1311653} Reviewers: chad Reviewed By: chad Maniphest Tasks: T10939 Differential Revision: https://secure.phabricator.com/D15914
This commit is contained in:
parent
4ba4cb9711
commit
70ddb1c45f
2 changed files with 2 additions and 2 deletions
|
@ -8,7 +8,7 @@ final class DifferentialProjectReviewersField
|
|||
}
|
||||
|
||||
public function getFieldName() {
|
||||
return pht('Project Reviewers');
|
||||
return pht('Coalition Reviewers');
|
||||
}
|
||||
|
||||
public function getFieldDescription() {
|
||||
|
|
|
@ -71,7 +71,7 @@ final class DifferentialReviewersField
|
|||
return id(new AphrontFormTokenizerControl())
|
||||
->setUser($this->getViewer())
|
||||
->setName($this->getFieldKey())
|
||||
->setDatasource(new PhabricatorProjectOrUserDatasource())
|
||||
->setDatasource(new DiffusionAuditorDatasource())
|
||||
->setValue($phids)
|
||||
->setError($this->getFieldError())
|
||||
->setLabel($this->getFieldName());
|
||||
|
|
Loading…
Reference in a new issue