revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
Code Issues Releases Wiki Activity

Allow packages to be added as revision reviewers via the UI

Browse source 
Summary:
Ref T10939. This lets you add packages as reviewers manually.

"Project Reviewers" now lists both projects and packages. I have renamed this to "Coalition Reviewers" but that's probably horrible and confusing. I'm not sure "Group Reviewers" is much better.

Test Plan:
  - Added a package as a reviewer manually.
  - Joined it, got authority over it.
  - Saw the review on my dashboard.
  - Accepted the revision, got authority extended to the package review.

{F1311652}

{F1311653}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10939

Differential Revision: https://secure.phabricator.com/D15914
This commit is contained in:
epriestley 2016-05-13 10:51:35 -07:00
parent 4ba4cb9711
commit 70ddb1c45f
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/customfield/DifferentialProjectReviewersField.php
View file

@ -8,7 +8,7 @@ final class DifferentialProjectReviewersField
} }
public function getFieldName() { public function getFieldName() {
return pht('Project Reviewers'); return pht('Coalition Reviewers');
} }
public function getFieldDescription() { public function getFieldDescription() {

2
src/applications/differential/customfield/DifferentialReviewersField.php
View file

@ -71,7 +71,7 @@ final class DifferentialReviewersField
return id(new AphrontFormTokenizerControl()) return id(new AphrontFormTokenizerControl())
->setUser($this->getViewer()) ->setUser($this->getViewer())
->setName($this->getFieldKey()) ->setName($this->getFieldKey())
->setDatasource(new PhabricatorProjectOrUserDatasource()) ->setDatasource(new DiffusionAuditorDatasource())
->setValue($phids) ->setValue($phids)
->setError($this->getFieldError()) ->setError($this->getFieldError())
->setLabel($this->getFieldName()); ->setLabel($this->getFieldName());