From 70e0deb368e7712f5fa0707916af08ffd72b549e Mon Sep 17 00:00:00 2001 From: Anh Nhan Nguyen Date: Tue, 2 Apr 2013 08:58:13 -0700 Subject: [PATCH] Empty list filters won't display if empty Summary: Exactly what it says on the tin Test Plan: No shadow when visiting saved custom queries in Maniphest. Still appears normally for other use sites Reviewers: epriestley, chad Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D5535 --- src/__celerity_resource_map__.php | 2 +- src/view/layout/AphrontListFilterView.php | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/__celerity_resource_map__.php b/src/__celerity_resource_map__.php index 2e5e8b0648..7f3cc63a6b 100644 --- a/src/__celerity_resource_map__.php +++ b/src/__celerity_resource_map__.php @@ -1253,7 +1253,7 @@ celerity_register_resource_map(array( ), 'javelin-behavior-conpherence-menu' => array( - 'uri' => '/res/08fcd75a/rsrc/js/application/conpherence/behavior-menu.js', + 'uri' => '/res/35811cd4/rsrc/js/application/conpherence/behavior-menu.js', 'type' => 'js', 'requires' => array( diff --git a/src/view/layout/AphrontListFilterView.php b/src/view/layout/AphrontListFilterView.php index 7470e5a059..8c30905615 100644 --- a/src/view/layout/AphrontListFilterView.php +++ b/src/view/layout/AphrontListFilterView.php @@ -3,6 +3,12 @@ final class AphrontListFilterView extends AphrontView { public function render() { + $contents = $this->renderChildren(); + + if (!$contents) { + return null; + } + require_celerity_resource('aphront-list-filter-view-css'); return hsprintf( '
'. @@ -12,7 +18,7 @@ final class AphrontListFilterView extends AphrontView { ''. ''. '
', - $this->renderChildren()); + $contents); } }