revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-15 10:00:55 +01:00
Code Issues Releases Wiki Activity

(stable) Make legacy revision statuses from "differential.query" have type "string" again

Browse source 
Summary:
Ref T2543. The type on these got changed by accident, it should be "string" (crazy nonsense, compatible) not "int" (sensible, not compatible).

(New API uses sensible strings like "accepted" only.)

Test Plan: Called `differential.query` from web UI, saw `"2"` and similar statuses.

Reviewers: chad, jmeador, lvital

Reviewed By: jmeador, lvital

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18493
This commit is contained in:
epriestley 2017-08-29 12:42:58 -07:00
parent 0171255986
commit 70ebdd2694
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php
View file

@ -218,7 +218,11 @@ final class DifferentialQueryConduitAPIMethod
'dateCreated' => $revision->getDateCreated(), 'dateCreated' => $revision->getDateCreated(),
'dateModified' => $revision->getDateModified(), 'dateModified' => $revision->getDateModified(),
'authorPHID' => $revision->getAuthorPHID(), 'authorPHID' => $revision->getAuthorPHID(),
'status' => $revision->getLegacyRevisionStatus(),
// NOTE: For backward compatibility this is explicitly a string, like
// "2", even though the value of the string is an integer. See PHI14.
'status' => (string)$revision->getLegacyRevisionStatus(),
'statusName' => $revision->getStatusDisplayName(), 'statusName' => $revision->getStatusDisplayName(),
'properties' => $revision->getProperties(), 'properties' => $revision->getProperties(),
'branch' => $diff->getBranch(), 'branch' => $diff->getBranch(),