From 70fd45b139054d876b58c8c78d7c7c864875ce19 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 9 Feb 2011 22:46:18 -0800 Subject: [PATCH] Use the correct actor handle when sending DifferentialNewDiffMail. Summary: Test Plan: Reviewers: CC: --- .../editor/revision/DifferentialRevisionEditor.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/applications/differential/editor/revision/DifferentialRevisionEditor.php b/src/applications/differential/editor/revision/DifferentialRevisionEditor.php index 5dff5ccade..99badd804d 100644 --- a/src/applications/differential/editor/revision/DifferentialRevisionEditor.php +++ b/src/applications/differential/editor/revision/DifferentialRevisionEditor.php @@ -353,6 +353,12 @@ class DifferentialRevisionEditor { $mail = array(); + $phids = array($this->getActorPHID()); + + $handles = id(new PhabricatorObjectHandleData($phids)) + ->loadHandles(); + $actor_handle = $handles[$this->getActorPHID()]; + $changesets = null; $comment = null; if ($diff) { @@ -364,7 +370,7 @@ class DifferentialRevisionEditor { if ($comment) { $mail[] = id(new DifferentialNewDiffMail( $revision, - $this->getActorPHID(), + $actor_handle, $changesets)) ->setIsFirstMailAboutRevision($is_new) ->setIsFirstMailToRecipients($is_new) @@ -418,12 +424,6 @@ class DifferentialRevisionEditor { $revision->loadRelationships(); - $phids = array($this->getActorPHID()); - - $handles = id(new PhabricatorObjectHandleData($phids)) - ->loadHandles(); - $actor_handle = $handles[$this->getActorPHID()]; - if ($add['rev']) { $message = id(new DifferentialNewDiffMail( $revision,