mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-25 16:22:43 +01:00
Fix PHP 8.1 "strlen(null)" exception querying project tags for autocomplete without additional hashtag slugs defined
Summary: `strlen()` was used in Phabricator to check if a generic value is a non-empty string. This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement. Note: this may highlight other absurd input values that might be worth correcting instead of just ignoring. If phutil_nonempty_string() throws an exception in your instance, report it to Phorge to evaluate and fix that specific corner case. ``` ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/project/typeahead/PhabricatorProjectDatasource.php:99] ``` Closes T15761 Test Plan: Go to a task, enter `#` and start typing a project tag of a project which has no additional slugs defined. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15761 Differential Revision: https://we.phorge.it/D25556
This commit is contained in:
parent
a69db10c5e
commit
713188bf17
1 changed files with 1 additions and 1 deletions
|
@ -96,7 +96,7 @@ final class PhabricatorProjectDatasource
|
||||||
|
|
||||||
// If we're building results for the autocompleter and this project
|
// If we're building results for the autocompleter and this project
|
||||||
// doesn't have any usable slugs, don't return it as a result.
|
// doesn't have any usable slugs, don't return it as a result.
|
||||||
if ($for_autocomplete && !strlen($slug)) {
|
if ($for_autocomplete && !phutil_nonempty_string($slug)) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in a new issue