revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Fail more gracefully when rendering transcripts if handle is missing

Browse source 
Summary: Fixes T4628. I can only partially reproduce the root cause here, but if transcript display rules aren't quite right we should just degrade here rather than fatalling. Transcripts are a messy business by any measure.

Test Plan: Sort-of-reproing transcript renders OK now.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4628

Differential Revision: https://secure.phabricator.com/D8554
This commit is contained in:
epriestley 2014-03-17 15:02:10 -07:00
parent aea624118b
commit 7167a729bf
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/herald/controller/HeraldTranscriptController.php
View file

@ -297,7 +297,9 @@ final class HeraldTranscriptController extends HeraldController {
default: default:
if ($target) { if ($target) {
foreach ($target as $k => $phid) { foreach ($target as $k => $phid) {
$target[$k] = $handles[$phid]->getName(); if (isset($handles[$phid])) {
$target[$k] = $handles[$phid]->getName();
}
} }
$target = implode("\n", $target); $target = implode("\n", $target);
} else { } else {