revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-18 12:52:42 +01:00
Code Issues Releases Wiki Activity

Clean up error state on Dashboards

Browse source 
Summary: A more basic error view

Test Plan:
Made stuff up

{F165315}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5319

Differential Revision: https://secure.phabricator.com/D9495
This commit is contained in:
Chad Little 2014-06-12 07:11:00 -07:00
parent 14198d62fb
commit 71d9a6be07
3 changed files with 19 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
resources/celerity/map.php
View file

@ -51,7 +51,7 @@ return array(
'rsrc/css/application/conpherence/widget-pane.css' => 'bf275a6c', 'rsrc/css/application/conpherence/widget-pane.css' => 'bf275a6c',
'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4', 'rsrc/css/application/contentsource/content-source-view.css' => '4b8b05d4',
'rsrc/css/application/countdown/timer.css' => '86b7b0a0', 'rsrc/css/application/countdown/timer.css' => '86b7b0a0',
'rsrc/css/application/dashboard/dashboard.css' => 'f593f8c2', 'rsrc/css/application/dashboard/dashboard.css' => 'f0092e3e',
'rsrc/css/application/diff/inline-comment-summary.css' => '8cfd34e8', 'rsrc/css/application/diff/inline-comment-summary.css' => '8cfd34e8',
'rsrc/css/application/differential/add-comment.css' => 'c478bcaa', 'rsrc/css/application/differential/add-comment.css' => 'c478bcaa',
'rsrc/css/application/differential/changeset-view.css' => 'ff8eacf8', 'rsrc/css/application/differential/changeset-view.css' => 'ff8eacf8',
@ -694,7 +694,7 @@ return array(
'phabricator-core-css' => '40151074', 'phabricator-core-css' => '40151074',
'phabricator-countdown-css' => '86b7b0a0', 'phabricator-countdown-css' => '86b7b0a0',
'phabricator-crumbs-view-css' => '7fbf25b8', 'phabricator-crumbs-view-css' => '7fbf25b8',
'phabricator-dashboard-css' => 'f593f8c2', 'phabricator-dashboard-css' => 'f0092e3e',
'phabricator-drag-and-drop-file-upload' => 'ae6abfba', 'phabricator-drag-and-drop-file-upload' => 'ae6abfba',
'phabricator-draggable-list' => '1681c4d4', 'phabricator-draggable-list' => '1681c4d4',
'phabricator-fatal-config-template-css' => '25d446d6', 'phabricator-fatal-config-template-css' => '25d446d6',

13
src/applications/dashboard/engine/PhabricatorDashboardPanelRenderingEngine.php
View file

@ -156,19 +156,24 @@ final class PhabricatorDashboardPanelRenderingEngine extends Phobject {
case self::HEADER_MODE_EDIT: case self::HEADER_MODE_EDIT:
$header = id(new PhabricatorActionHeaderView()) $header = id(new PhabricatorActionHeaderView())
->setHeaderTitle($title) ->setHeaderTitle($title)
->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED); ->setHeaderColor(PhabricatorActionHeaderView::HEADER_WHITE);
$header = $this->addPanelHeaderActions($header); $header = $this->addPanelHeaderActions($header);
break; break;
case self::HEADER_MODE_NORMAL: case self::HEADER_MODE_NORMAL:
default: default:
$header = id(new PhabricatorActionHeaderView()) $header = id(new PhabricatorActionHeaderView())
->setHeaderTitle($title) ->setHeaderTitle($title)
->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED); ->setHeaderColor(PhabricatorActionHeaderView::HEADER_WHITE);
break; break;
} }
$icon = id(new PHUIIconView())
->setIconFont('fa-warning red msr');
$content = id(new PHUIBoxView())
->addClass('dashboard-box')
->appendChild($icon)
->appendChild($body);
return $this->renderPanelDiv( return $this->renderPanelDiv(
id(new AphrontErrorView()) $content,
->appendChild($body),
$header); $header);
} }

8
webroot/rsrc/css/application/dashboard/dashboard.css
View file

@ -75,3 +75,11 @@
.aphront-multi-column-column .aphront-error-view { .aphront-multi-column-column .aphront-error-view {
margin: 0; margin: 0;
} }
.dashboard-panel .dashboard-box {
padding: 12px;
background: #fff;
border-left: 1px solid {$lightblueborder};
border-right: 1px solid {$lightblueborder};
border-bottom: 1px solid {$blueborder};
}