revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-22 05:20:56 +01:00
Code Issues Releases Wiki Activity

When a diff has 12,345 lines, render "12,345 lines" instead of "12 lines"

Browse source 
Summary: This `%d` should be a `%s`, since the `PhutilNumber` value may get formatted according to locale settings.

Test Plan: will make @zeeg

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley, zeeg

Differential Revision: https://secure.phabricator.com/D8814
This commit is contained in:
epriestley 2014-04-18 17:52:11 -07:00
parent 9889892e5b
commit 71ef48b3e5
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/editor/DifferentialTransactionEditor.php
View file

@ -1070,7 +1070,7 @@ final class DifferentialTransactionEditor
switch ($strongest->getTransactionType()) { switch ($strongest->getTransactionType()) {
case DifferentialTransaction::TYPE_UPDATE: case DifferentialTransaction::TYPE_UPDATE:
$count = new PhutilNumber($object->getLineCount()); $count = new PhutilNumber($object->getLineCount());
$action = pht('%s, %d line(s)', $action, $count); $action = pht('%s, %s line(s)', $action, $count);
break; break;
} }

6
src/infrastructure/internationalization/translation/PhabricatorBaseEnglishTranslation.php
View file

@ -856,9 +856,9 @@ abstract class PhabricatorBaseEnglishTranslation
'%d older changes are hidden.', '%d older changes are hidden.',
), ),
'%s, %d line(s)' => array( '%s, %s line(s)' => array(
'%s, %d line', '%s, %s line',
'%s, %d lines', '%s, %s lines',
), ),
'%s pushed %d commit(s) to %s.' => array( '%s pushed %d commit(s) to %s.' => array(