revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-05 12:21:02 +01:00
Code Issues Releases Wiki Activity

Various minor JSHint fixes.

Browse source 
Summary: Various fixes as suggested by JSHint.

Test Plan: Eye-balled it.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9783
This commit is contained in:
Joshua Spence 2014-07-01 06:00:12 +10:00
parent 6d51958b5c
commit 7304e29dec
5 changed files with 12 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
support/aphlict/server/aphlict_server.js
View file

@ -62,10 +62,9 @@ if (process.getuid() !== 0) {
var net = require('net'); var net = require('net');
var http = require('http'); var http = require('http');
var url = require('url');
process.on('uncaughtException', function(err) { process.on('uncaughtException', function(err) {
debug.log("\n<<< UNCAUGHT EXCEPTION! >>>\n" + err.stack); debug.log('\n<<< UNCAUGHT EXCEPTION! >>>\n' + err.stack);
process.exit(1); process.exit(1);
}); });
@ -188,7 +187,7 @@ var receive_server = http.createServer(function(request, response) {
} }
}); });
} else if (request.url == '/status/') { } else if (request.url == '/status/') {
request.on('data', function(data) { request.on('data', function() {
// We just ignore the request data, but newer versions of Node don't // We just ignore the request data, but newer versions of Node don't
// get to 'end' if we don't process the data. See T2953. // get to 'end' if we don't process the data. See T2953.
}); });
@ -213,7 +212,6 @@ var receive_server = http.createServer(function(request, response) {
response.write('400 Bad Request'); response.write('400 Bad Request');
response.end(); response.end();
} }
}).listen(config.admin, config.host); }).listen(config.admin, config.host);
function transmit(msg) { function transmit(msg) {

4
support/aphlict/server/lib/AphlictFlashPolicyServer.js
View file

@ -46,7 +46,7 @@ JX.install('AphlictFlashPolicyServer', {
this._log('<FlashPolicy> Socket Error: %s', error); this._log('<FlashPolicy> Socket Error: %s', error);
}, },
_log: function(pattern) { _log: function() {
this._debug && this._debug.log.apply(this._debug, arguments); this._debug && this._debug.log.apply(this._debug, arguments);
}, },
@ -60,7 +60,7 @@ JX.install('AphlictFlashPolicyServer', {
'</cross-domain-policy>' '</cross-domain-policy>'
]; ];
return policy.join("\n") + "\0"; return policy.join('\n') + '\0';
} }
} }

4
support/aphlict/server/lib/AphlictLog.js
View file

@ -32,7 +32,7 @@ JX.install('AphlictLog', {
return this; return this;
}, },
log: function(pattern) { log: function() {
var str = util.format.apply(null, arguments); var str = util.format.apply(null, arguments);
var date = new Date().toLocaleString(); var date = new Date().toLocaleString();
str = '[' + date + '] ' + str; str = '[' + date + '] ' + str;
@ -43,7 +43,7 @@ JX.install('AphlictLog', {
} }
for (ii = 0; ii < this._writeToLogs.length; ii++) { for (ii = 0; ii < this._writeToLogs.length; ii++) {
this._writeToLogs[ii].write(str + "\n"); this._writeToLogs[ii].write(str + '\n');
} }
} }

4
webroot/rsrc/js/application/differential/behavior-comment-jump.js
View file

@ -7,7 +7,7 @@
JX.behavior('differential-comment-jump', function() { JX.behavior('differential-comment-jump', function() {
function handle_jump(offset) { function handle_jump(offset) {
return (function(e) { return function(e) {
var parent = JX.$('differential-review-stage'); var parent = JX.$('differential-review-stage');
var clicked = e.getNode('differential-inline-comment'); var clicked = e.getNode('differential-inline-comment');
var inlines = JX.DOM.scry(parent, 'div', 'differential-inline-comment'); var inlines = JX.DOM.scry(parent, 'div', 'differential-inline-comment');
@ -24,7 +24,7 @@ JX.behavior('differential-comment-jump', function() {
}); });
JX.DOM.scrollTo(jumpto); JX.DOM.scrollTo(jumpto);
e.kill(); e.kill();
}); };
} }
JX.Stratcom.listen('click', 'differential-inline-prev', handle_jump(-1)); JX.Stratcom.listen('click', 'differential-inline-prev', handle_jump(-1));

8
webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js
View file

@ -131,12 +131,12 @@ JX.behavior('phabricator-remarkup-assist', function(config) {
break; break;
case 'fa-code': case 'fa-code':
sel = sel || 'foreach ($list as $item) {\n work_miracles($item);\n}'; sel = sel || 'foreach ($list as $item) {\n work_miracles($item);\n}';
var prefix = (r.start === 0) ? '' : '\n'; var code_prefix = (r.start === 0) ? '' : '\n';
update(area, prefix + '```\n', sel, '\n```'); update(area, code_prefix + '```\n', sel, '\n```');
break; break;
case 'fa-table': case 'fa-table':
var prefix = (r.start === 0 ? '' : '\n\n'); var table_prefix = (r.start === 0 ? '' : '\n\n');
update(area, prefix + '| ', sel || pht('data'), ' |'); update(area, table_prefix + '| ', sel || pht('data'), ' |');
break; break;
case 'fa-meh-o': case 'fa-meh-o':
new JX.Workflow('/macro/meme/create/') new JX.Workflow('/macro/meme/create/')