From 733ae2a2e94c7713bea4cc8c71e3bb2f18a34615 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 4 May 2017 17:00:02 -0700 Subject: [PATCH] Explicitly quote "From" name part when submitting mail to the Mailgun API Summary: We are submitting `epriestley (Evan Priestley) `, but should be submitting `"epriestley (Evan Priestley)" `. Add the missing quotes. Test Plan: Locally, this makes the API calls work against the Mailgun sandbox domain. Reviewers: chad, amckinley Reviewed By: chad, amckinley Differential Revision: https://secure.phabricator.com/D17831 --- .../adapter/PhabricatorMailImplementationMailgunAdapter.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php b/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php index 0890ac3004..cfe6491fe0 100644 --- a/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php +++ b/src/applications/metamta/adapter/PhabricatorMailImplementationMailgunAdapter.php @@ -86,7 +86,7 @@ final class PhabricatorMailImplementationMailgunAdapter $from = idx($this->params, 'from'); if (idx($this->params, 'from-name')) { - $params['from'] = "{$this->params['from-name']} <{$from}>"; + $params['from'] = "\"{$this->params['from-name']}\" <{$from}>"; } else { $params['from'] = $from; }