From 82bfb9817920bbd6f75d27cbbf4555e310b826b0 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 10 Jan 2018 13:32:44 -0800
Subject: [PATCH 1/2] Fix a copy/paste error on the burnup chart

Summary: See PHI286, maybe. See PHI273. Strongly considering just deleting this.

Test Plan: ~.~

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18865
---
 .../maniphest/controller/ManiphestReportController.php          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
index 3ba597fb92..4f546d04c5 100644
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -140,7 +140,7 @@ final class ManiphestReportController extends ManiphestController {
       }
 
       $oldv = trim($row['oldValue'], '"');
-      $newv = trim($row['oldValue'], '"');
+      $newv = trim($row['newValue'], '"');
 
       // If this is a status change, preserve it.
       if ($oldv != 'null') {

From 3e983b583dc0b5c46aa0702b346fbd552766a318 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 16 Jan 2018 11:01:29 -0800
Subject: [PATCH 2/2] Fix a transposed feed story in Badges

Summary: See <https://discourse.phabricator-community.org/t/badge-quality-from-and-to-interchanged-in-activity-log/987>. These are swapped.

Test Plan: Changed a badge quality, viewed feed story, saw it position the strings correctly.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18870
---
 .../xaction/PhabricatorBadgesBadgeQualityTransaction.php    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php b/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php
index de060c17e7..fc1bf014c0 100644
--- a/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php
+++ b/src/applications/badges/xaction/PhabricatorBadgesBadgeQualityTransaction.php
@@ -37,11 +37,11 @@ final class PhabricatorBadgesBadgeQualityTransaction
     $new = $this->getQualityLabel($this->getNewValue());
 
     return pht(
-      '%s updated %s quality from %s to %s.',
+      '%s updated the quality of %s from %s to %s.',
       $this->renderAuthor(),
       $this->renderObject(),
-      $new,
-      $old);
+      $old,
+      $new);
   }
 
   public function validateTransactions($object, array $xactions) {