From 735120b842718c9bf7f40e86a9f0691b740f1e39 Mon Sep 17 00:00:00 2001 From: epriestley Date: Thu, 18 Aug 2011 12:58:52 -0700 Subject: [PATCH] Fix bug where CC value is ignored on intial parse from commit message Summary: While I thought this was complicated, there was nothing subtle or tricky here -- I just misnamed a variable. Test Plan: Created a revision with default CCs, got CCs instead of nothing. Reviewers: aran, jungejason, tuomaspelkonen Reviewed By: aran CC: aran Differential Revision: 834 --- .../specification/ccs/DifferentialCCsFieldSpecification.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/applications/differential/field/specification/ccs/DifferentialCCsFieldSpecification.php b/src/applications/differential/field/specification/ccs/DifferentialCCsFieldSpecification.php index 74107b02a0..8799bf40fb 100644 --- a/src/applications/differential/field/specification/ccs/DifferentialCCsFieldSpecification.php +++ b/src/applications/differential/field/specification/ccs/DifferentialCCsFieldSpecification.php @@ -98,7 +98,7 @@ final class DifferentialCCsFieldSpecification } public function setValueFromParsedCommitMessage($value) { - $this->value = nonempty($value, array()); + $this->ccs = nonempty($value, array()); return $this; }