revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 00:42:41 +01:00
Code Issues Releases Wiki Activity

Skip "null" lines when constructing raw documents for DocumentEngine rendering

Browse source 
Summary: See <https://discourse.phabricator-community.org/t/more-exceptions-when-viewing-diffs/3789>. This is a similar issue with the same datastructure.

Test Plan: Works correctly under PHP 7.3, but this may not be the end of things.

Differential Revision: https://secure.phabricator.com/D21171
This commit is contained in:
epriestley 2020-04-25 17:27:58 -07:00
parent a226d74133
commit 7355bb7f29
1 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/differential/parser/DifferentialChangesetParser.php
View file

@ -1901,9 +1901,13 @@ final class DifferentialChangesetParser extends Phobject {
$text = array(); $text = array();
foreach ($lines as $line) { foreach ($lines as $line) {
if ($line === null) {
continue;
}
// If this is a "No newline at end of file." annotation, don't hand it // If this is a "No newline at end of file." annotation, don't hand it
// off to the DocumentEngine. // off to the DocumentEngine.
if ($line['type'] == '\\') { if ($line['type'] === '\\') {
continue; continue;
} }