revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-21 11:09:02 +01:00
Code Issues Releases Wiki Activity

Fix a possible count(null) in DifferentialRevisionActionTransaction

Browse source 
Summary:
This change prevents the following error when using PHP 7.2:

```
ERROR 2: count(): Parameter must be an array or an object that implements Countable at [/usr/local/lib/php/phabricator/src/applications/differential/xaction/DifferentialRevisionActionTransaction.php:132]
```

A similar issue was fixed in D18964

Test Plan: Tested in a live system.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D19242
This commit is contained in:
Tino Breddin 2018-03-21 07:39:34 -07:00 • committed by epriestley
parent 3bf8d5682e
commit 73b68bc2a6
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
View file

@ -80,7 +80,7 @@ abstract class DifferentialRevisionActionTransaction
DifferentialRevision $revision) { DifferentialRevision $revision) {
return array( return array(
array(), array(),
null, array(),
); );
} }