From 73ed316c5d2e5bb4092940729827f7877306394e Mon Sep 17 00:00:00 2001 From: Austin McKinley Date: Mon, 15 May 2017 13:22:05 -0700 Subject: [PATCH] (stable) Fix breakage of Pholio Summary: Removal of `PholioMockEditor::applyCustomInternalTransaction()` in D17868 broke creation of new mocks in Pholio. Puts the empty method back until we finish migrating Pholio to modular transactions. Test Plan: Created some mocks, observed lack of unhandled exception. Reviewers: #blessed_reviewers, epriestley Reviewed By: #blessed_reviewers, epriestley Subscribers: epriestley Differential Revision: https://secure.phabricator.com/D17889 --- src/applications/pholio/editor/PholioMockEditor.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/applications/pholio/editor/PholioMockEditor.php b/src/applications/pholio/editor/PholioMockEditor.php index 6f5bf1df2b..322eaa7267 100644 --- a/src/applications/pholio/editor/PholioMockEditor.php +++ b/src/applications/pholio/editor/PholioMockEditor.php @@ -184,6 +184,12 @@ final class PholioMockEditor extends PhabricatorApplicationTransactionEditor { return null; } + protected function applyCustomInternalTransaction( + PhabricatorLiskDAO $object, + PhabricatorApplicationTransaction $xaction) { + return; + } + protected function applyCustomExternalTransaction( PhabricatorLiskDAO $object, PhabricatorApplicationTransaction $xaction) {