revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Select all available bodies when rendering a feed story

Browse source 
Summary:
Fixes T4060. The logic here is:

  - When you take several actions at once, we show a single feed story for all of them.
  - We choose the "most interesting" title for the feed story. For example, "close task" is more interesting than "add CC".

Currently, the issue with this is:

  - "Add comment" is the //least interesting// title. I think this is correct: all other actions are more interesting than the fact that you added a comment.
  - We try to conserve the number of objects we need to load by rendering only the most interesting transaction.

To fix this:

  - Stop being so conservative; load all of the transactions and all of their PHIDs.
  - Add bodies from any transactions which render bodies. In all cases (I think?) this is a maximum of one comment adding a body.

The end result is a story like this:

  epriestley closed T123: the building is on fire.

  "Okay guys I put the fire out"

Test Plan: See screenshot.

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran, asherkin

Maniphest Tasks: T4060

Differential Revision: https://secure.phabricator.com/D7504
This commit is contained in:
epriestley 2013-11-05 09:03:59 -08:00
parent b3f36a94a1
commit 7414777856
1 changed files with 20 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/applications/transactions/feed/PhabricatorApplicationTransactionFeedStory.php
View file

@ -11,16 +11,19 @@ class PhabricatorApplicationTransactionFeedStory
} }
public function getRequiredObjectPHIDs() { public function getRequiredObjectPHIDs() {
return array( return $this->getValue('transactionPHIDs');
$this->getPrimaryTransactionPHID(),
);
} }
public function getRequiredHandlePHIDs() { public function getRequiredHandlePHIDs() {
$phids = array(); $phids = array();
$phids[] = array($this->getValue('objectPHID')); $phids[] = $this->getValue('objectPHID');
$phids[] = $this->getPrimaryTransaction()->getRequiredHandlePHIDs(); foreach ($this->getValue('transactionPHIDs') as $xaction_phid) {
return array_mergev($phids); $xaction = $this->getObject($xaction_phid);
foreach ($xaction->getRequiredHandlePHIDs() as $handle_phid) {
$phids[] = $handle_phid;
}
}
return $phids;
} }
protected function getPrimaryTransactionPHID() { protected function getPrimaryTransactionPHID() {
@ -40,18 +43,23 @@ class PhabricatorApplicationTransactionFeedStory
$view->setAppIconFromPHID($handle->getPHID()); $view->setAppIconFromPHID($handle->getPHID());
$xaction_phids = $this->getValue('transactionPHIDs'); $xaction_phids = $this->getValue('transactionPHIDs');
$xaction = $this->getObject(head($xaction_phids)); $xaction = $this->getPrimaryTransaction();
$xaction->setHandles($this->getHandles()); $xaction->setHandles($this->getHandles());
$view->setTitle($xaction->getTitleForFeed($this)); $view->setTitle($xaction->getTitleForFeed($this));
$body = $xaction->getBodyForFeed($this);
foreach ($xaction_phids as $xaction_phid) {
$secondary_xaction = $this->getObject($xaction_phid);
$secondary_xaction->setHandles($this->getHandles());
$body = $secondary_xaction->getBodyForFeed($this);
if (nonempty($body)) { if (nonempty($body)) {
$view->appendChild($body); $view->appendChild($body);
} }
}
$view->setImage( $view->setImage(
$this->getHandle( $this->getHandle($xaction->getAuthorPHID())->getImageURI());
$this->getPrimaryTransaction()->getAuthorPHID())->getImageURI());
return $view; return $view;
} }