From 7446402f921a5625178e47c6da24b7f786f33165 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Thu, 3 Apr 2014 12:01:04 -0700 Subject: [PATCH] Differential Action List on Mobile Summary: Make the actions appear in crumbs on mobile Test Plan: Test action list on a mobile diff layout Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4730 Differential Revision: https://secure.phabricator.com/D8691 --- .../controller/DifferentialRevisionViewController.php | 1 + .../view/DifferentialRevisionDetailView.php | 11 +++++++++++ 2 files changed, 12 insertions(+) diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php index 6906e77ebd..a2f6a2a8cb 100644 --- a/src/applications/differential/controller/DifferentialRevisionViewController.php +++ b/src/applications/differential/controller/DifferentialRevisionViewController.php @@ -420,6 +420,7 @@ final class DifferentialRevisionViewController extends DifferentialController { $crumbs = $this->buildApplicationCrumbs(); $crumbs->addTextCrumb($object_id, '/'.$object_id); + $crumbs->setActionList($revision_detail->getActionList()); $prefs = $user->loadPreferences(); diff --git a/src/applications/differential/view/DifferentialRevisionDetailView.php b/src/applications/differential/view/DifferentialRevisionDetailView.php index 1294ad9dad..cf4222dbdb 100644 --- a/src/applications/differential/view/DifferentialRevisionDetailView.php +++ b/src/applications/differential/view/DifferentialRevisionDetailView.php @@ -7,6 +7,7 @@ final class DifferentialRevisionDetailView extends AphrontView { private $customFields; private $diff; private $uri; + private $actionList; public function setURI($uri) { $this->uri = $uri; @@ -37,6 +38,15 @@ final class DifferentialRevisionDetailView extends AphrontView { return $this->actions; } + public function setActionList(PhabricatorActionListView $list) { + $this->actionList = $list; + return $this; + } + + public function getActionList() { + return $this->actionList; + } + public function setCustomFields(PhabricatorCustomFieldList $list) { $this->customFields = $list; return $this; @@ -95,6 +105,7 @@ final class DifferentialRevisionDetailView extends AphrontView { $properties->setHasKeyboardShortcuts(true); $properties->setActionList($actions); + $this->setActionList($actions); $field_list = $this->customFields; if ($field_list) {