From 74a0caf9ce166465ccf5d62b646d977073cca3c5 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Fri, 16 Dec 2016 06:51:01 -0800
Subject: [PATCH] Remove "Author" CustomField in Differential

Summary: Ref T11114. This hasn't done anything since we moved author information to the subheader.

Test Plan: Browsed Differential, still saw author information.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17071
---
 src/__phutil_library_map__.php                |  2 -
 .../PhabricatorDifferentialConfigOptions.php  |  1 -
 .../customfield/DifferentialAuthorField.php   | 38 -------------------
 3 files changed, 41 deletions(-)
 delete mode 100644 src/applications/differential/customfield/DifferentialAuthorField.php

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
index 27df51bc02..9807448068 100644
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -354,7 +354,6 @@ phutil_register_library_map(array(
     'DifferentialAsanaRepresentationField' => 'applications/differential/customfield/DifferentialAsanaRepresentationField.php',
     'DifferentialAuditorsCommitMessageField' => 'applications/differential/field/DifferentialAuditorsCommitMessageField.php',
     'DifferentialAuditorsField' => 'applications/differential/customfield/DifferentialAuditorsField.php',
-    'DifferentialAuthorField' => 'applications/differential/customfield/DifferentialAuthorField.php',
     'DifferentialBlameRevisionCommitMessageField' => 'applications/differential/field/DifferentialBlameRevisionCommitMessageField.php',
     'DifferentialBlameRevisionField' => 'applications/differential/customfield/DifferentialBlameRevisionField.php',
     'DifferentialBlockHeraldAction' => 'applications/differential/herald/DifferentialBlockHeraldAction.php',
@@ -4998,7 +4997,6 @@ phutil_register_library_map(array(
     'DifferentialAsanaRepresentationField' => 'DifferentialCustomField',
     'DifferentialAuditorsCommitMessageField' => 'DifferentialCommitMessageCustomField',
     'DifferentialAuditorsField' => 'DifferentialStoredCustomField',
-    'DifferentialAuthorField' => 'DifferentialCustomField',
     'DifferentialBlameRevisionCommitMessageField' => 'DifferentialCommitMessageCustomField',
     'DifferentialBlameRevisionField' => 'DifferentialStoredCustomField',
     'DifferentialBlockHeraldAction' => 'HeraldAction',
diff --git a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
index 6083c2a97f..4bd2b68849 100644
--- a/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
+++ b/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
@@ -30,7 +30,6 @@ final class PhabricatorDifferentialConfigOptions
       new DifferentialTitleField(),
       new DifferentialSummaryField(),
       new DifferentialTestPlanField(),
-      new DifferentialAuthorField(),
       new DifferentialReviewersField(),
       new DifferentialProjectReviewersField(),
       new DifferentialReviewedByField(),
diff --git a/src/applications/differential/customfield/DifferentialAuthorField.php b/src/applications/differential/customfield/DifferentialAuthorField.php
deleted file mode 100644
index fbd74dd2ab..0000000000
--- a/src/applications/differential/customfield/DifferentialAuthorField.php
+++ /dev/null
@@ -1,38 +0,0 @@
-<?php
-
-final class DifferentialAuthorField
-  extends DifferentialCustomField {
-
-  public function getFieldKey() {
-    return 'differential:author';
-  }
-
-  public function getFieldName() {
-    return pht('Author');
-  }
-
-  public function getFieldDescription() {
-    return pht('Stores the revision author.');
-  }
-
-  public function canDisableField() {
-    return false;
-  }
-
-  public function shouldAppearInPropertyView() {
-    return false;
-  }
-
-  public function renderPropertyViewLabel() {
-    return $this->getFieldName();
-  }
-
-  public function getRequiredHandlePHIDsForPropertyView() {
-    return array($this->getObject()->getAuthorPHID());
-  }
-
-  public function renderPropertyViewValue(array $handles) {
-    return $handles[$this->getObject()->getAuthorPHID()]->renderHovercardLink();
-  }
-
-}