From 74e42d7ccec67403620df12f5aa570812bf20058 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Sun, 25 May 2014 16:30:32 -0700 Subject: [PATCH] clean up tablet view, group tiles. --- .../controller/PhabricatorHomeController.php | 19 ------------------- .../PhabricatorHomeQuickCreateController.php | 1 + .../view/PhabricatorApplicationLaunchView.php | 4 +--- .../rsrc/css/aphront/phabricator-nav-view.css | 5 +++++ 4 files changed, 7 insertions(+), 22 deletions(-) diff --git a/src/applications/home/controller/PhabricatorHomeController.php b/src/applications/home/controller/PhabricatorHomeController.php index 00f8bc386a..0e1223984e 100644 --- a/src/applications/home/controller/PhabricatorHomeController.php +++ b/src/applications/home/controller/PhabricatorHomeController.php @@ -114,25 +114,6 @@ abstract class PhabricatorHomeController extends PhabricatorController { $tiles[] = $tile; } - if ($is_small_tiles) { - while (count($tiles) % 3) { - $tiles[] = id(new PhabricatorApplicationLaunchView()); - } - $label = id(new PHUIListItemView()) - ->setType(PHUIListItemView::TYPE_LABEL) - ->setName($groups[$group]); - - if ($is_hide) { - $label_id = celerity_generate_unique_node_id(); - $attrs = array(); - $label->setStyle('display: none;'); - $label->setID($label_id); - $tile_ids[] = $label_id; - } - - $nav->addMenuItem($label); - } - $group_id = celerity_generate_unique_node_id(); $tile_ids[] = $group_id; $nav->addCustomBlock( diff --git a/src/applications/home/controller/PhabricatorHomeQuickCreateController.php b/src/applications/home/controller/PhabricatorHomeQuickCreateController.php index cf4394daad..2c1bd0ea2d 100644 --- a/src/applications/home/controller/PhabricatorHomeQuickCreateController.php +++ b/src/applications/home/controller/PhabricatorHomeQuickCreateController.php @@ -9,6 +9,7 @@ final class PhabricatorHomeQuickCreateController $items = $this->getCurrentApplication()->loadAllQuickCreateItems($viewer); $list = id(new PHUIObjectItemListView()) + ->setCards(true) ->setUser($viewer); foreach ($items as $item) { diff --git a/src/applications/meta/view/PhabricatorApplicationLaunchView.php b/src/applications/meta/view/PhabricatorApplicationLaunchView.php index 7863390b7f..2217273357 100644 --- a/src/applications/meta/view/PhabricatorApplicationLaunchView.php +++ b/src/applications/meta/view/PhabricatorApplicationLaunchView.php @@ -23,7 +23,6 @@ final class PhabricatorApplicationLaunchView extends AphrontView { $content = array(); $icon = null; - $create_button = null; if ($application) { $content[] = phutil_tag( 'span', @@ -127,7 +126,6 @@ final class PhabricatorApplicationLaunchView extends AphrontView { $classes = array(); $classes[] = 'phabricator-application-launch-container'; - $classes[] = 'application-tile-full'; $app_button = phutil_tag( $application ? 'a' : 'div', @@ -140,6 +138,6 @@ final class PhabricatorApplicationLaunchView extends AphrontView { $content, )); - return array($app_button, $create_button); + return $app_button; } } diff --git a/webroot/rsrc/css/aphront/phabricator-nav-view.css b/webroot/rsrc/css/aphront/phabricator-nav-view.css index 6aeb7bd00a..97ff40a3f5 100644 --- a/webroot/rsrc/css/aphront/phabricator-nav-view.css +++ b/webroot/rsrc/css/aphront/phabricator-nav-view.css @@ -44,6 +44,11 @@ display: block; } +.device-desktop .phabricator-side-menu-home .phabricator-nav-content, +.device-tablet .phabricator-side-menu-home .phabricator-nav-content { + margin-left: 205px; +} + .phabricator-nav-local { width: 205px; position: absolute;