From 754397c4e75d748e9a193e42c0ca2305be6106f0 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 11 Oct 2016 15:37:46 -0700 Subject: [PATCH] Fix some minor UI issues with mobile application search Summary: Background is now always white, spacing in header is more consistent Test Plan: test mobile, table, desktop application search apps. Reviewers: epriestley Reviewed By: epriestley Subscribers: Korvin Differential Revision: https://secure.phabricator.com/D16691 --- resources/celerity/map.php | 6 +++--- .../PhabricatorApplicationSearchController.php | 2 +- .../css/application/search/application-search-view.css | 10 ++++++++++ 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 1e25a4cd03..bb082d5a78 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -9,7 +9,7 @@ return array( 'names' => array( 'conpherence.pkg.css' => '4601645d', 'conpherence.pkg.js' => '11f3e07e', - 'core.pkg.css' => 'b8364d01', + 'core.pkg.css' => '7ca260a3', 'core.pkg.js' => '30185d95', 'darkconsole.pkg.js' => 'e7393ebb', 'differential.pkg.css' => 'e1d704ce', @@ -102,7 +102,7 @@ return array( 'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5', 'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd', 'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae', - 'rsrc/css/application/search/application-search-view.css' => 'be6454ec', + 'rsrc/css/application/search/application-search-view.css' => '8452c849', 'rsrc/css/application/search/search-results.css' => '7dea472c', 'rsrc/css/application/slowvote/slowvote.css' => 'a94b7230', 'rsrc/css/application/tokens/tokens.css' => '3d0f239e', @@ -610,7 +610,7 @@ return array( 'aphront-tokenizer-control-css' => '056da01b', 'aphront-tooltip-css' => '1a07aea8', 'aphront-typeahead-control-css' => 'd4f16145', - 'application-search-view-css' => 'be6454ec', + 'application-search-view-css' => '8452c849', 'auth-css' => '0877ed6e', 'bulk-job-css' => 'df9c1d4a', 'changeset-view-manager' => 'a2828756', diff --git a/src/applications/search/controller/PhabricatorApplicationSearchController.php b/src/applications/search/controller/PhabricatorApplicationSearchController.php index 6350df5e02..92a8181b4f 100644 --- a/src/applications/search/controller/PhabricatorApplicationSearchController.php +++ b/src/applications/search/controller/PhabricatorApplicationSearchController.php @@ -329,7 +329,6 @@ final class PhabricatorApplicationSearchController $crumbs->addTextCrumb($title); } - $nav->addClass('application-search-view'); require_celerity_resource('application-search-view-css'); return $this->newPage() @@ -337,6 +336,7 @@ final class PhabricatorApplicationSearchController ->setTitle(pht('Query: %s', $title)) ->setCrumbs($crumbs) ->setNavigation($nav) + ->addClass('application-search-view') ->appendChild($body); } diff --git a/webroot/rsrc/css/application/search/application-search-view.css b/webroot/rsrc/css/application/search/application-search-view.css index 4a573f5111..1320df9c0f 100644 --- a/webroot/rsrc/css/application/search/application-search-view.css +++ b/webroot/rsrc/css/application/search/application-search-view.css @@ -11,6 +11,11 @@ padding: 0 16px 24px; } +.device-phone .application-search-view + .application-search-results.phui-object-box { + padding: 0 12px 24px; +} + .application-search-view .application-search-results .phui-profile-header { padding: 16px 8px; border-bottom: 1px solid {$thinblueborder}; @@ -31,6 +36,11 @@ padding: 12px 0; } +.device-phone .application-search-results + .phui-profile-header.phui-header-shell { + padding: 12px 0 12px 4px; +} + .device-phone .application-search-results .phui-profile-header.phui-header-shell .phui-header-header { font-size: 16px;