Update differential.close to use DifferentialTransactionEditor

Summary: Ref T2222. Straightforward update to new stuff.

Test Plan:
  - Tried to close an uncloseable revision.
  - Closed a closeable revision.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8425

src/applications/differential/conduit/ConduitAPI_differential_Method.php

@@ -1,8 +1,5 @@
 <?php
 
-/**
- * @group conduit
- */
 abstract class ConduitAPI_differential_Method extends ConduitAPIMethod {
 
   public function getApplication() {

src/applications/differential/conduit/ConduitAPI_differential_close_Method.php

@@ -1,13 +1,10 @@
 <?php
 
-/**
- * @group conduit
- */
 final class ConduitAPI_differential_close_Method
-  extends ConduitAPIMethod {
+  extends ConduitAPI_differential_Method {
 
   public function getMethodDescription() {
-    return "Close a Differential revision.";
+    return pht("Close a Differential revision.");
   }
 
   public function defineParamTypes() {
@@ -27,40 +24,34 @@ final class ConduitAPI_differential_close_Method
   }
 
   protected function execute(ConduitAPIRequest $request) {
+    $viewer = $request->getUser();
     $id = $request->getValue('revisionID');
 
     $revision = id(new DifferentialRevisionQuery())
       ->withIDs(array($id))
-      ->setViewer($request->getUser())
+      ->setViewer($viewer)
-      ->needRelationships(true)
       ->needReviewerStatus(true)
       ->executeOne();
     if (!$revision) {
       throw new ConduitException('ERR_NOT_FOUND');
     }
 
-    if ($revision->getStatus() == ArcanistDifferentialRevisionStatus::CLOSED) {
+    $xactions = array();
-      // This can occur if someone runs 'close-revision' and hits a race, or
+    $xactions[] = id(new DifferentialTransaction())
-      // they have a remote hook installed but don't have the
+      ->setTransactionType(DifferentialTransaction::TYPE_ACTION)
-      // 'remote_hook_installed' flag set, or similar. In any case, just treat
+      ->setNewValue(DifferentialAction::ACTION_CLOSE);
-      // it as a no-op rather than adding another "X closed this revision"
-      // message to the revision comments.
-      return;
-    }
 
     $content_source = PhabricatorContentSource::newForSource(
       PhabricatorContentSource::SOURCE_CONDUIT,
       array());
 
-    $editor = new DifferentialCommentEditor(
+    $editor = id(new DifferentialTransactionEditor())
-      $revision,
+      ->setActor($viewer)
-      DifferentialAction::ACTION_CLOSE);
+      ->setContentSourceFromConduitRequest($request)
-    $editor->setContentSource($content_source);
+      ->setContinueOnMissingFields(true)
-    $editor->setActor($request->getUser());
+      ->setContinueOnNoEffect(true);
-    $editor->save();
 
-    $revision->setStatus(ArcanistDifferentialRevisionStatus::CLOSED);
+    $editor->applyTransactions($revision, $xactions);
-    $revision->save();
 
     return;
   }

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

@@ -450,6 +450,16 @@ abstract class PhabricatorApplicationTransactionEditor
       PhabricatorContentSource::newFromRequest($request));
   }
 
+  public function setContentSourceFromConduitRequest(
+    ConduitAPIRequest $request) {
+
+    $content_source = PhabricatorContentSource::newForSource(
+      PhabricatorContentSource::SOURCE_CONDUIT,
+      array());
+
+    return $this->setContentSource($content_source);
+  }
+
   public function getContentSource() {
     return $this->contentSource;
   }