revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-19 18:28:39 +01:00
Code Issues Releases Wiki Activity

Config migration script bug fix

Browse source 
Summary: i think way back in D10490 I didn't incorporate feedback correctly. make this code right as it fatals in this codepath as is. Fixes T6508.

Test Plan: @joshuaspence to the rescue  (I remain unable to test this effectively with my baby-clean installation.)

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley, joshuaspence

Maniphest Tasks: T6508

Differential Revision: https://secure.phabricator.com/D10833
This commit is contained in:
Bob Trahan 2014-11-11 15:05:57 -08:00
parent b462a80cca
commit 755c518631
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/config/management/PhabricatorConfigManagementMigrateWorkflow.php
View file

@ -55,13 +55,14 @@ final class PhabricatorConfigManagementMigrateWorkflow
'Skipping option "%s"; already in database config.', $key)."\n"); 'Skipping option "%s"; already in database config.', $key)."\n");
continue; continue;
} else { } else {
PhabricatorConfigEditor::deleteConfig( PhabricatorConfigEditor::storeNewValue(
$this->getViewer(), $this->getViewer(),
$option, id(new PhabricatorConfigEntry())
->loadOneWhere('namespace = %s AND key = %s', 'default', $key),
PhabricatorContentSource::newConsoleSource()); PhabricatorContentSource::newConsoleSource());
$key_count++; $key_count++;
$console->writeOut(pht( $console->writeOut(pht(
'Migrated option "%s" from file to local config.', $key)."\n"); 'Migrated option "%s" from file to database config.', $key)."\n");
} }
} }
} }