revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-30 01:10:58 +01:00
Code Issues Releases Wiki Activity

[Redesign] Cleanup Harbormaster UI

Browse source 
Summary: Ref T8099, adds StatusIcons in place of barColor. May need to revisit icons. Also fixed incorrect icons used in Drydock.

Test Plan: Visit Harbormaster, Drydock, see proper icons.

Reviewers: btrahan, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8099

Differential Revision: https://secure.phabricator.com/D13054
This commit is contained in:
Chad Little 2015-05-28 13:00:26 -07:00
parent 3699253e49
commit 75673a8e37
5 changed files with 15 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/drydock/view/DrydockLeaseListView.php
View file

@ -42,9 +42,9 @@ final class DrydockLeaseListView extends AphrontView {
$item->setEpoch($lease->getDateCreated());
if ($lease->isActive()) {
$item->setStatusIcon('fa-dot-circle green');
$item->setStatusIcon('fa-dot-circle-o green');
} else {
$item->setStatusIcon('fa-dot-circle red');
$item->setStatusIcon('fa-dot-circle-o red');
}
$view->addItem($item);

8
src/applications/drydock/view/DrydockResourceListView.php
View file

@ -27,16 +27,16 @@ final class DrydockResourceListView extends AphrontView {
switch ($resource->getStatus()) {
case DrydockResourceStatus::STATUS_PENDING:
$item->setStatusIcon('fa-dot-circle yellow');
$item->setStatusIcon('fa-dot-circle-o yellow');
break;
case DrydockResourceStatus::STATUS_OPEN:
$item->setStatusIcon('fa-dot-circle green');
$item->setStatusIcon('fa-dot-circle-o green');
break;
case DrydockResourceStatus::STATUS_DESTROYED:
$item->setStatusIcon('fa-times-circle black');
$item->setStatusIcon('fa-times-circle-o black');
break;
default:
$item->setStatusIcon('fa-dot-circle red');
$item->setStatusIcon('fa-dot-circle-o red');
break;
}

4
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
View file

@ -175,7 +175,9 @@ final class HarbormasterBuildableViewController
->setHref($view_uri);
$status = $build->getBuildStatus();
$item->setBarColor(HarbormasterBuild::getBuildStatusColor($status));
$item->setStatusIcon(
'fa-dot-circle-o '.HarbormasterBuild::getBuildStatusColor($status),
HarbormasterBuild::getBuildStatusName($status));
$item->addAttribute(HarbormasterBuild::getBuildStatusName($status));

6
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
View file

@ -122,7 +122,7 @@ final class HarbormasterPlanViewController extends HarbormasterPlanController {
$item = id(new PHUIObjectItemView())
->setObjectName(pht('Step %d.%d', $depth, $i))
->setHeader(pht('Unknown Implementation'))
->setBarColor('red')
->setStatusIcon('fa-warning red')
->addAttribute(pht(
'This step has an invalid implementation (%s).',
$step->getClassName()))
@ -208,7 +208,7 @@ final class HarbormasterPlanViewController extends HarbormasterPlanController {
if ($has_conflicts) {
$has_any_conflicts = true;
$item->setBarColor('red');
$item->setStatusIcon('fa-warning red');
}
if ($run_ref['cycle']) {
@ -216,7 +216,7 @@ final class HarbormasterPlanViewController extends HarbormasterPlanController {
}
if ($is_deadlocking) {
$item->setBarColor('red');
$item->setStatusIcon('fa-warning red');
}
$step_list->addItem($item);

6
src/applications/people/controller/PhabricatorPeopleLdapController.php
View file

@ -101,17 +101,17 @@ final class PhabricatorPeopleLdapController
$header = pht('Successfully added %s', $username);
$attribute = null;
$color = 'green';
$color = 'fa-check green';
} catch (Exception $ex) {
$header = pht('Failed to add %s', $username);
$attribute = $ex->getMessage();
$color = 'red';
$color = 'fa-times red';
}
$item = id(new PHUIObjectItemView())
->setHeader($header)
->addAttribute($attribute)
->setBarColor($color);
->setStatusIcon($color);
$list->addItem($item);
}