From 7574be5372fe7aaeedb7ce47052cc0c1112f82fb Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Thu, 7 Mar 2019 14:04:27 -0800
Subject: [PATCH] Remove opacity effects for left-side / right-side diff text
 selection

Summary:
These effects feel like they're possibly overkill, since other CSS rules make the selection reticle behave correctly and the implementation is relatively intuitive.

Or not, either way.

Test Plan: Selected text on either side of a 2-up diff, no more opacity effects.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D20264
---
 resources/celerity/map.php                           | 12 ++++++------
 .../css/application/differential/changeset-view.css  |  5 -----
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
index 00a62f41d6..0e963428bc 100644
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -11,7 +11,7 @@ return array(
     'conpherence.pkg.js' => '020aebcf',
     'core.pkg.css' => '34ce1741',
     'core.pkg.js' => 'b96c872e',
-    'differential.pkg.css' => '1755a478',
+    'differential.pkg.css' => '8d8360fb',
     'differential.pkg.js' => '67e02996',
     'diffusion.pkg.css' => '42c75c37',
     'diffusion.pkg.js' => '91192d85',
@@ -61,7 +61,7 @@ return array(
     'rsrc/css/application/dashboard/dashboard.css' => '4267d6c6',
     'rsrc/css/application/diff/inline-comment-summary.css' => '81eb368d',
     'rsrc/css/application/differential/add-comment.css' => '7e5900d9',
-    'rsrc/css/application/differential/changeset-view.css' => '4193eeff',
+    'rsrc/css/application/differential/changeset-view.css' => 'bde53589',
     'rsrc/css/application/differential/core.css' => '7300a73e',
     'rsrc/css/application/differential/phui-inline-comment.css' => '48acce5b',
     'rsrc/css/application/differential/revision-comment.css' => '7dbc8d1d',
@@ -542,7 +542,7 @@ return array(
     'conpherence-thread-manager' => 'aec8e38c',
     'conpherence-transaction-css' => '3a3f5e7e',
     'd3' => 'd67475f5',
-    'differential-changeset-view-css' => '4193eeff',
+    'differential-changeset-view-css' => 'bde53589',
     'differential-core-view-css' => '7300a73e',
     'differential-revision-add-comment-css' => '7e5900d9',
     'differential-revision-comment-css' => '7dbc8d1d',
@@ -1210,9 +1210,6 @@ return array(
       'javelin-behavior',
       'javelin-uri',
     ),
-    '4193eeff' => array(
-      'phui-inline-comment-view-css',
-    ),
     '4234f572' => array(
       'syntax-default-css',
     ),
@@ -1901,6 +1898,9 @@ return array(
       'javelin-vector',
       'javelin-stratcom',
     ),
+    'bde53589' => array(
+      'phui-inline-comment-view-css',
+    ),
     'c03f2fb4' => array(
       'javelin-install',
     ),
diff --git a/webroot/rsrc/css/application/differential/changeset-view.css b/webroot/rsrc/css/application/differential/changeset-view.css
index 844690abd3..233ac4cca5 100644
--- a/webroot/rsrc/css/application/differential/changeset-view.css
+++ b/webroot/rsrc/css/application/differential/changeset-view.css
@@ -451,7 +451,6 @@ unselectable. */
   -ms-user-select: none;
   -webkit-user-select: none;
   user-select: none;
-  opacity: 0.5;
 }
 
 .differential-diff.copy-l > tbody > tr > td:nth-child(2) {
@@ -459,7 +458,6 @@ unselectable. */
   -ms-user-select: auto;
   -webkit-user-select: auto;
   user-select: auto;
-  opacity: 1;
 }
 
 .differential-diff.copy-l > tbody > tr > td.show-more:nth-child(2) {
@@ -467,7 +465,6 @@ unselectable. */
   -ms-user-select: none;
   -webkit-user-select: none;
   user-select: none;
-  opacity: 0.5;
 }
 
 .differential-diff.copy-r > tbody > tr > td:nth-child(5) {
@@ -475,7 +472,6 @@ unselectable. */
   -ms-user-select: auto;
   -webkit-user-select: auto;
   user-select: auto;
-  opacity: 1;
 }
 
 .differential-diff.copy-l > tbody > tr.inline > td,
@@ -484,5 +480,4 @@ unselectable. */
   -ms-user-select: none;
   -webkit-user-select: none;
   user-select: none;
-  opacity: 0.5;
 }